Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove detach hack in useChannel #1796

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: remove detach hack in useChannel #1796

merged 1 commit into from
Jun 20, 2024

Conversation

ttypic
Copy link
Collaborator

@ttypic ttypic commented Jun 19, 2024

channel.listeners.length is always 1, so detach never invokes anyway. We should put detach into ChannelProvider see #1795

`channel.listeners.length` is always 1, so detach never invoked anyway. We should put detach into `ChannelProvider` later
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since it doesn't do anything rn anyway.

Is there an explanation somewhere available to why we wanted to do this in the first place? So we can correctly document the reasoning for #1795

@ttypic
Copy link
Collaborator Author

ttypic commented Jun 19, 2024

@VeskeR, added reasoning for #1795

@ttypic ttypic requested a review from owenpearson June 19, 2024 17:24
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fwiw the original justification for this is in the commit message here but I agree that we're better off without it 👍

@ttypic ttypic merged commit b7e5156 into main Jun 20, 2024
11 of 12 checks passed
@ttypic ttypic deleted the remove-timeout-hack branch June 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants