[MMB-44] Ensure we're setting proper error codes #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surminus
changed the title
The majority of errors we are throwing are default InvalidArgumentError type errors. Otherwise, we only really have two other errors: 1. Attempting to connect to a space where the name is missing 2. Trying to do something when they have entered a space I've copied the way that locks used errors.
Let's ensure we never have a throw that isn't at least a standard generic error code.
surminus
force-pushed
the
mmb-44-error-codes
branch
from
f397291
to
33bb373
Compare
|
@Srushtika I went with OUT_OF_SPACE error as a reference to the Prodigy song, but I'm happy to do something more useful as suggested! 😉 |
|
@Srushtika updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of errors we are throwing are default InvalidArgumentError type errors.
Otherwise, we only really have two other errors:
I've copied the way that locks used errors.