Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MMB-44] Ensure we're setting proper error codes #135

Merged
merged 4 commits into from
Aug 25, 2023
Merged

[MMB-44] Ensure we're setting proper error codes #135

merged 4 commits into from
Aug 25, 2023

Commits on Aug 25, 2023

  1. Ensure we're setting proper error codes 

    The majority of errors we are throwing are default InvalidArgumentError
type errors.

Otherwise, we only really have two other errors:

1. Attempting to connect to a space where the name is missing
2. Trying to do something when they have entered a space

I've copied the way that locks used errors.
    @surminus
    surminus committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    a658ec9 View commit details
    Browse the repository at this point in the history

  2. Ensure proper standard errors are being set 

    Let's ensure we never have a throw that isn't at least a standard
generic error code.
    @surminus
    surminus committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    33bb373 View commit details
    Browse the repository at this point in the history

  3. fixup! Ensure we're setting proper error codes

    @surminus
    surminus committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    6a2e961 View commit details
    Browse the repository at this point in the history

  4. fixup! Ensure we're setting proper error codes

    @surminus
    surminus committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    4e4d4f1 View commit details
    Browse the repository at this point in the history