Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TO3g editing in place for clarity. #194

Merged
merged 2 commits into from
Jul 5, 2024
Merged

TO3g editing in place for clarity. #194

merged 2 commits into from
Jul 5, 2024

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Jun 22, 2024 •
edited
Loading

I want to make it more clear that the spec is about user data and presence messages (MESSAGE and PRESENCE).

@github-actions github-actions bot temporarily deployed to staging/pull/194 June 22, 2024 22:05 Inactive
@maratal maratal requested review from SimonWoolf, ttypic and sacOO7 June 22, 2024 22:05
maratal added a commit to ably/ably-cocoa that referenced this pull request Jun 22, 2024
@maratal
Only queue publish and presence messages (TO3g, see also ably/specifi…
022b2ac 
…cation#194).
maratal added a commit to ably/ably-cocoa that referenced this pull request Jun 23, 2024
@maratal
Only queue publish and presence messages (TO3g, see also ably/specifi…
9eac54c 
…cation#194).
sacOO7
sacOO7 reviewed Jun 24, 2024
View reviewed changes
textile/features.textile Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/194 June 24, 2024 13:06 Inactive
@maratal maratal force-pushed the TO3g-clarification branch from 2beaa2c to cffcb3f Compare June 24, 2024 13:11
@github-actions github-actions bot temporarily deployed to staging/pull/194 June 24, 2024 13:12 Inactive
@maratal maratal force-pushed the TO3g-clarification branch from cffcb3f to ef10bc1 Compare June 24, 2024 13:16
@github-actions github-actions bot temporarily deployed to staging/pull/194 June 24, 2024 13:16 Inactive
@maratal maratal force-pushed the TO3g-clarification branch from ef10bc1 to cf5fe3b Compare June 24, 2024 13:19
@github-actions github-actions bot temporarily deployed to staging/pull/194 June 24, 2024 13:20 Inactive
ttypic
ttypic reviewed Jun 24, 2024
View reviewed changes
textile/features.textile Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/194 June 24, 2024 13:35 Inactive
@maratal maratal force-pushed the TO3g-clarification branch from b1a46dd to a015fe1 Compare June 24, 2024 13:40
@github-actions github-actions bot temporarily deployed to staging/pull/194 June 24, 2024 13:41 Inactive
ttypic
ttypic approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maratal maratal mentioned this pull request Jun 29, 2024
Closed
maratal added a commit to ably/ably-cocoa that referenced this pull request Jun 29, 2024
@maratal
Only queue publish and presence messages (TO3g, see also ably/specifi…
21744f1 
…cation#194).
@maratal maratal mentioned this pull request Jun 29, 2024
Merged
maratal added a commit to ably/ably-cocoa that referenced this pull request Jun 30, 2024
@maratal
Only queue publish and presence messages (TO3g, see also ably/specifi…
16b3806 
…cation#194).
@maratal maratal merged commit e8bd89a into main Jul 5, 2024
2 checks passed
@maratal maratal deleted the TO3g-clarification branch July 5, 2024 00:14
@maratal maratal restored the TO3g-clarification branch July 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacOO7 sacOO7 sacOO7 left review comments

@ttypic ttypic ttypic approved these changes

@SimonWoolf SimonWoolf SimonWoolf approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maratal @SimonWoolf @ttypic @sacOO7