[ECO-4858] TO3g compliance #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch from `onConnected`).
maratal
force-pushed
the
fix/1940-TO3g-violation
branch
from
21744f1 to
16b3806
Compare
maratal
force-pushed
the
fix/1940-TO3g-violation
branch
from
5634ed8 to
586c255
Compare
|
Closed by mistake |
This was
linked to
issues
Jul 1, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1936, #1938 and #1940
These three bugs were cancelling each other, so it's impossible to address them in different PRs since to fix all the tests failures you need to fix other two bugs. Please see commit messages and review per commit basis.
See also ably/specification#194
Some additional info for commits messages.
d60269a "Proceeding with detach on
CONNECTED":What happens here is that in addition to re-attach we need re-detach as well to continue the process after connection becomes
CONNECTED. But in oppose toattachthere were no internal method for doing so, that's why I've splitted_detachintointernalDetach:which doesn't do state check before proceeding with detaching. Also because detach message shouldn't be queued I've removedshouldQueueEventscheck from thedetachAfterChecks.305d8db "Sending queued messages should be after reattach":
If you send message before sending
ATTACH, realtime won't respond and tests will timeout. You can check it withtest__065__Channel__publish__Message_connectionId_should_match_the_current_Connection_id_for_all_published_messagestest.16b3806 "Only queue publish and presence messages":
The check
else if (msg.ackRequired)you should read as "if message can be queued", sinceACKrequired with the same condition as queuing - message is eitherMESSAGEorPRESENCE. Also I've added log line if message sending was ignored.