add st license #900
add st license #900
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #900 +/- ##
===========================================
- Coverage 79.07% 78.83% -0.25%
===========================================
Files 93 93
Lines 11456 11456
===========================================
- Hits 9059 9031 -28
- Misses 2397 2425 +28
Continue to review full report at Codecov.
|
Signed-off-by: inishchith <inishchith@gmail.com>
| @@ -0,0 +1,34 @@ | |||
| Copyright (c) 2017 STMicroelectronics – All rights reserved | |||
There was a problem hiding this comment.
Can you remove this copyright line from the reference license text? We want to avoid mixing copyrights in licenses in most cases.
| SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR | ||
| OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY | ||
| OF SUCH DAMAGE. |
There was a problem hiding this comment.
Please add a trailing new line
| owner: STMicroelectronics International N.V. | ||
| homepage_url: http://www.st.com/content/st_com/en.html | ||
| text_urls: | ||
| - https://github.com/STMicroelectronics-CentralLabs/BlueSTSDK_GUI_iOS/blob/master/LICENSE |
There was a problem hiding this comment.
Can you use 4 spaces for indent there?
|
@pombredanne i've made the required changes . |
|
@inishchith kind reminder that I need your "Signed-off-by: inishchith inishchith@gmail.com" line on every commit, and you could also come with more explicit commit messages (or squash them all in one?) |
|
@pombredanne Sorry , this time i had issues with my remote branch so had no other way :) |
|
Fair enough. I take care of squashing this alright! |
| key: st-microelectronics | ||
| short_name: STMicroelectronics CentralLabs License | ||
| name: STMicroelectronics CentralLabs License | ||
| category: Permissive Free |
There was a problem hiding this comment.
Since it has some serious restrictions on redistribution of graphics, I wonder if the category should be something else. @DennisClark what do you think?
There was a problem hiding this comment.
I am making this free restricted instead.... FWIW there is no such "Permissive Free" category anyway
PR for issue : #662
Signed-off-by: inishchith inishchith@gmail.com
@pombredanne need your review . I figured out that it's a Permissive Free License .