Support dynamic Enum value #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwilson512
reviewed
Jan 5, 2021
| @@ -145,7 +145,7 @@ defmodule Absinthe.Blueprint.Schema do | |||
| end | |||
|
|
|||
| defp build_types([{:values, values} | rest], [enum | stack], buff) do | |||
| enum = Map.update!(enum, :values, &(values ++ &1)) | |||
| enum = Map.update!(enum, :values, &(List.wrap(values) ++ &1)) | |||
There was a problem hiding this comment.
What is the need to wrap these in a list?
There was a problem hiding this comment.
Ahh, yes this is the sneaky bit. Now that values are wrap_in_unquote'd it can now be a list of atoms or AST for a function call - so I just wrap everything in a list here so that it can continue to collect in a list.
Then in the end after this all is injected into __absinthe_blueprint__ it'll be some form of nested list, and I can call List.flatten(type_def.values) to get the final resulting list....
binaryseed
force-pushed
the
dynamic-enum-values
branch
from
80f2660
to
4031ae9
Compare
binaryseed
force-pushed
the
dynamic-enum-values
branch
from
4031ae9
to
31327dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for dynamic Enum values in macro based schemas using
unqoutelike in #1005