Mark root objects as referenced #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of_correct_type_bug Account for `nil` schema_node in ArgumentsOfCorrectType suggestions
Fix `nil` schema_node in ArgumentsOfCorrectType
Introduce telemetry events to Async middleware to instrument new `Task.async/1` created inside the middleware. The use-case for this event comes from OpenTelemetry and trace propagation. For OTel, we need to run instrumentation from inside the newly created Task to be able to connect spans. With this event in place, we can track those Tasks without introducing custom wrappers on user code. This patch adds events only in the case of the middleware creating the task. For tasks created by user code, there is nothing the library can do, unfortunately.
…re-telemetry Add telemetry events to async middleware
The Spandex library needs a 'completion_time' and it's not possible to get the start time at the beginning of the span to calculate it based on the duration
Add end_time_mono to telemetry :stop events
…ve_ergonomics Allow single atom for macro directives
This is necessary if we want to extend it. It also cleans up some code that checks for the presence of a declaration.
This way it's easier to check for the presence of a declaration when applying type extensions.
This is no longer necessary as every schema has a proper schema declaration struct.
The filtering of the SchemaDeclaration is not necessary here as this is already done in the ApplyDeclaration phase.
This is also covered by validation phases, and with this check the extension of query/mutation/subscription objects is not possible.
…ecification-links update old specification links
Fixed a typo preventing to format files located in priv
…declaration_directives Allow schema declaration directives
…arsing Parse constant values separate from locations that permit variables
Followup to absinthe-graphql#1176 Since every schema will have a declared or inferred declaration, this can be used to mark root objects as referenced. The MarkReferenced used to mark every :query/:subscription/:mutation object as referenced, even when it was used in the declaration. This fix ensures that root objects that are not used in the declaration are not marked as referenced and thus not rendered in the SDL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettyflag to custom codecs, add tests (Fix mix task to passprettyflag to custom codecs, add tests absinthe-graphql/absinthe#676)on_load/2resolution helper__using__args for Absinthe.Schema.Notation ignored in 1.5 absinthe-graphql/absinthe#685use Absinthe.Schema.Prototype(Easy extension of built-in (schema) directives for SDL absinthe-graphql/absinthe#747)nil.identifier/0fromimport_sdlwith a directive like@foo(a: { b: {} })absinthe-graphql/absinthe#831.hydrate_dynamic_values_test.exsendto dataloader exampledataloader/2function to helpers (Adddataloader/2function to helpers absinthe-graphql/absinthe#898)repeatableon directive declarationAbsinthe.Language.*structs to graphql representation (ConvertAbsinthe.Language.*structs to graphql representation absinthe-graphql/absinthe#1114)telemetry_span_contextfollowing conventions (Addtelemetry_span_contextfollowing conventions absinthe-graphql/absinthe#1128)__private__field to EnumValueDefinition struct (Add__private__field to EnumValueDefinition struct absinthe-graphql/absinthe#1148)extendlanguage struct to bp structextend/1to locals_without_parensextendmacro