Fixes escape character sequences that are not on the last attributes #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with attributes that have escape characters and attributes
on the same line the order of the attributes matters for the outcome. If
the slashes appear in the last attribute then everything parses
successfully. If the attribute appears earlier in the list then an error
is returned instead.
The error:
~~~elixir
validation_errors: [
%Absinthe.Phase.Error{
extra: %{},
locations: [%{column: 0, line: 1}],
message: "illegal: \") { name } }",
path: [],
phase: Absinthe.Phase.Parse
}
]
~~~
This change allows the attributes to come in any order.
Amos King @adkron <amos@binarynoggin.com>
|
i like the solution :) i would embrace the '' between '' in the message |
|
👍 Good catch. |
|
@bruce can you review this? |
|
I believe this may be obviated by our move to NimbleParsec in 1.5, @bruce are you able to confirm that? |
|
This tests fine on master; I'm going to merge. The lexer change will disappear with the lexer switch, but the tests will be handy. |
|
No problem. Thanks for taking care of it.
Amos King
Binary Noggin
… On Sep 19, 2018, at 17:42, Bruce Williams ***@***.***> wrote:
Confirmed the switch to nimble_parsec fixes this issue as well; merged & tests pass in master and in #503.
Thanks for your work on this, @adkron; even though the fix was superseded, the tests are great to have around. Sorry for the delay in reviewing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #588
When running with attributes that have escape characters and
on the same line the order of the attributes matters for the outcome. If
the slashes appear in the last attribute, then everything parses
successfully. If the property appears earlier in the list, then an error
is returned instead.
The error:
This change allows the attributes to come in any order.
Amos King @adkron amos@binarynoggin.com