Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes escape character sequences that are not on the last attributes #590

Merged
merged 2 commits into from
Sep 19, 2018

Commits on Aug 1, 2018

  1. Fixes escape character sequences that are not on the last attributes

    When running with attributes that have escape characters and attributes
    on the same line the order of the attributes matters for the outcome. If
    the slashes appear in the last attribute then everything parses
    successfully. If the attribute appears earlier in the list then an error
    is returned instead.
    
    The error:
    
    ~~~elixir
      validation_errors: [
        %Absinthe.Phase.Error{
          extra: %{},
          locations: [%{column: 0, line: 1}],
          message: "illegal: \") { name } }",
          path: [],
          phase: Absinthe.Phase.Parse
        }
      ]
    ~~~
    
    This change allows the attributes to come in any order.
    
    Amos King @adkron <amos@binarynoggin.com>
    adkron committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    a4ecb4e View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Fix typo in test name

    bruce committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    ad2f7b8 View commit details
    Browse the repository at this point in the history