Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapped unknown types #1138

Merged

Conversation

maartenvanvliet
Copy link
Contributor

@maartenvanvliet maartenvanvliet commented Jan 5, 2022

I noticed that wrapped unknown types were not marked as errors by the Absinthe.Phase.Validation.KnownTypeNames phase.

E.g.

query Foo($var: UnknownType) { user { id } }

would trigger an error but

query Foo($var: UnknownType!) { user { id } }

wouldn't.
Downstream in other phases this error would still be picked up because e.g. the variable type would not match up to the argument, but the error message was vague.

I added a fix for this and also changed the error message to include "Did you mean?" suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants