Feature/did you mean input objects #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stions for inputs
…est for name suggestions
benwilson512
requested changes
Apr 8, 2020
| @@ -79,7 +79,14 @@ defmodule Absinthe.Phase.Document.Validation.ArgumentsOfCorrectType do | |||
| node.fields | |||
| |> Enum.flat_map(fn | |||
| %{flags: %{invalid: _}, schema_node: nil} = child -> | |||
| [unknown_field_error_message(child.name)] | |||
| field_suggestions = | |||
| case node.schema_node do | |||
There was a problem hiding this comment.
You should Type.unwrap(node.schema_node) because this could be wrapped in non_null.
There was a problem hiding this comment.
Used this line as example, should I change this one also? It's not related with the new feature!
…d add test case to non-null suggestion
benwilson512
approved these changes
Apr 9, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It address #314.
The steps to make things happen are:
Utilsmodule, so both input and objects can use the same implementation.I've based the tests on current ones, feel free to request new tests where necessary to avoid any regressions.
I also have no sure about the
Utilsmodule inside/validationdir is a good pattern, since each module inside/validationmaps directly to a step, I've created this newUtilsthing to differentiate it.Suggestions are always welcome! : )