Fix mix task to pass pretty flag to custom codecs, add tests
#676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure that pretty argument gets passed to custom encoder
|
Just some context behind this -- I need this fix in order to support pretty formatting in a custom codec I wrote that generates schemas with types sorted alphabetically. This results in cleaner diffs when committing schema files to version control. See https://github.com/hadfieldn/absinthe_sorting_codec |
hide public functions that are provided only for testing
|
Thanks for the helpful feedback @benwilson512. I implemented your suggestions and also cleaned up the docs a bit. |
|
@benwilson512 Since this issue prevents the use of custom codecs in 1.4, would it be okay to create another PR that applies these changes to that branch? |
|
Yup!
…On Sat, Jan 26, 2019 at 5:37 PM Nathan Hadfield ***@***.***> wrote:
@benwilson512 <https://github.com/benwilson512> Since this issue prevents
the use of custom codecs in 1.4, would it be okay to create another PR that
applies these changes to that branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#676 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPICVA4QINYMqeqmyMT3CEK3hBtYD82ks5vHNivgaJpZM4aUEOd>
.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue preventing the
prettyflag from being passed to custom codecs. It also adds tests to ensure that CLI options are parsed correctly, appropriate defaults are used, and custom codecs are called successfully.Note that in order to make the tests perform an actual conversion to JSON, we would have to add Jason or Poison as a test-mode dependency. I opted against this because if we can ensure that the codec is accessed correctly, the risk of Poison's or Jason's
encode/2method failing should be low.However, if we don't add Jason or Poison as production-mode dependencies, we may want .to update the README to indicate that the application must load the the codec module in order for the mix task to work, even if using the default Jason encoder.