Add missing information in 1.5 upgrade guide #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwilson512
requested changes
Oct 12, 2021
guides/upgrading/v1.5.md
Outdated
|
|
||
| Scalar outputs are now type checked and will raise exceptions if the result tries to send the wrong data type in the result. | ||
|
|
||
| Scalar variables are now type checked too and will raise exceptions when clients try to send a query with invalid variable definitions. |
There was a problem hiding this comment.
This is not an accurate characterization, please use the changelog as a reference. The issue is more nuanced than just scalar variables, and it will not raise exceptions, it will return errors.
There was a problem hiding this comment.
Sorry, amended. 🙏
dorian-marchal
force-pushed
the
fix-1.5-upgrade-guide
branch
from
329e845
to
f6e1e8e
Compare
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following-up: #1107