Add telemetry_span_context following conventions
#1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absinthe's telemetry events includes `id` metadata, as means to correlate start/stop/exception events. Telemetry defines a `telemetry_span_context` for this same reasons. This patch publishes the same `id` value as both keys, sowe maintain backwards compatibility as well keep adherent to conventions, for tools that rely on that - like OpenTelemetry. The `telemetry_span_context` is generated using `:erlang.make_ref/0`. Given typespecs describe as `term`, should be safe to use the same value as `id`.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absinthe's telemetry events includes
idmetadata, as means to correlate start/stop/exception events. Telemetry defines atelemetry_span_contextfor this same reasons.This patch publishes the same
idvalue as both keys, so we maintain backwards compatibility as well keep adherent to conventions, for tools that rely on that - like OpenTelemetry.The
telemetry_span_contextis generated using:erlang.make_ref/0. Given typespecs describe asterm, should be safe to use the same value asid.