V.12.3.1 PR1C #17
Merged
V.12.3.1 PR1C #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Rev1 as its never been used
Move hashing files to Lyra2RE
* Add tests for special rules for slow blocks on devnet/testnet * add 20m and 3h
* CTxLockCandidate serialization * COutPointLock serialization * CInstantSend serialization * Read/write instantsend.dat file * Read\write InstantSend cache only if InstantSend is enabled
…o mix up to 16 rounds (dashpay#2128) * Allows a user to mix up to 16 rounds All codebase appears to accept up to 16 rounds, however this form was capped at 8; restricting users to 2-8 rounds. This commit allows a user to actually use up to 16 rounds in practice. This will greatly enhance the privacy of those very worried about their privacy, as well as possibly increasing liquidity and increasing the privacy of all users. * Up the default for PS mixing to 4 rounds.
* adjust `AddLocal` method only in regtest mode * Create Masternodes in regtest * sentinelping call for masternodes * set externalip option for masternodes in regtest * fix MNB relay during masternodes creation * fix node_count naming * instantsend doublespend * decrease node restarts * prevent spending masternode collaterals * move long test to the test list start * remove InstantSend spork sending * remove spork-specific code * fix checking double spend rejection
* .gitnore visual studio bs * Improves the readability of the `GetOutpointPrivateSendRounds` function by not having the second argument be needed, as the second arg should only not be 0 when it is recursively calling itself * Revert ".gitnore visual studio bs" This reverts commit 129b524. * changed back comment and fixed allignment * refactor based on Udjin's suggestions. * refactor based on Udjin's suggestions. * fix alignment * Revert "fix alignment" This reverts commit c2cc2ae. * actually fix alignment * actually fix alignment
* fix whitespace * added zmq stuff for governance objects and votes it seems that zmq is currently not in a working state, need to figure that out. Need to: plug in the new methods added possibly plug in the old methods, as it doesn't look like they are. * formatting fix. Will probably need to revert for this PR * continue linking new zmq messages in * added comment, might need to revert * fixes error of it not knowing about the classes * Actually link in, all new govobjects and govvotes should be broadcast over zmq now. * fix compile error, forgot to change params when copying * fix compile error * add imports to the header files in zmqconfig.h * fixing linking(i think) error * Revert "added comment, might need to revert" This reverts commit 2918ea4. * Revert "formatting fix. Will probably need to revert for this PR" This reverts commit ca10558. * fix tabs etc * EOL added * optimization of hash.begin() @nmarley thoughts? * remove formatting changes * iterator i -> it and removal of notifier * typo in df879f5 * use auto for the iterators * introduce hash prefix * implement changes in zmq_sub.py, update the doc, and change argument name to fix typo * deref iterators before calling methods * continued e8a4c50 * missed one... continued e8a4c50 * killing some tabs * fix spacing for setting or comparing iterators * change order of new variables to match current setup * re-add elif's I didn't realize got removed * Revert "fix spacing for setting or comparing iterators" This reverts commit 8ce2068. * Revert "use auto for the iterators" This reverts commit cb16cf0. * Revert "missed one... continued e8a4c50" This reverts commit 2087cf8. * Revert "continued e8a4c50" This reverts commit a78c8ad. * Revert "deref iterators before calling methods" This reverts commit e8a4c50. * Revert "iterator i -> it and removal of notifier" This reverts commit 2957424. * Revert "fix whitespace" This reverts commit 612be48. * Revert "typo in df879f5" * Revert "Optimization of hash.begin()" * fixes problem with revert * Udjin complain's a lot ;) * help text, init.cpp * add signals in validationinterface.cpp * Change location of vote notification call. * remain consistent * remove unneeded include due to change of notification location * implement raw notifications
* iterator cleanup in Dash-specific code * const * *Pair/pair * it++ -> ++it
* replace map count/insert w/emplace in instantx.cpp
This feels like an optimization, something about:
```
if map.count(key)
return false
else
insert(pair)
return true
```
... just feels icky. Plus, `vote.GetMasternodeOutpoint()` is only called
once. The previous version might be slightly more readable, however.
* use std::pair template constructor shortcut
This is recommended in modern C++ code as nullptr is more type-safe and can't be converted to an integer, unlike NULL
These are occurring every second and cause more noise than actual information.
Replcae scheduled tasks * Fix rare crash when trying to shutdown wallet during mixing Should stop PS and release all keys _before_ wallet is destroyed. * fix nowallet * update doc
* fixes dashpay#2068 * Revert prior and update in correct location
Since backporting Bitcoin 0.14 code, we have the arm-linux-gnueabihf and aarch64-linux-gnu hosts in gitian-linux.yml
We mostly switched to python3, so we should also install it in gitian builds. Especially the osx build needs as it otherwise fails due to missing setuptools.
…2184) * use bloom filters for IX lock votes * code style fixes
* Use subdirectory for depends cache in gitian builds * Make timestamps of wrappers deterministic * Use ccache in gitian builds * Upgrade ccache to latest version (3.4.2) * Build the branch that belongs to the Jenkins build instead of develop
…2189) * No need for pointers to gobjects, can simply use hashes in RequestGovernanceObjectVotes * Drop `swap` and `=` in GovernanceObject Were used for shuffling, no longer needed
…shpay#2190) * Make sure pwalletMain is not null whenever it's used in PS client * partially revert
Also show a warning that the file must be kept secure.
* remove instandsenddepth option * remove CInstantSend::GetConfirmations * Explicit IXlocks processing in the code using GetDepthInMainChain * remove dummy confirmations for IX locks * remove unused constant * Track IS status in TransactionStatus * Highlight IS in tx list * Customize confirmation icons for IS txes * Fix issues: - bring back removed comment; - simplify 2 complex condition to ose `IsTrusted()` function only; - rename `IsLockedIX` function to 'IsLockedByInstantSend`; * Revert condition with IsTrusted() * code style fix * remove dummy confirmations from instantsend.md * fix instantsend.md
Needed since we added Chia bls-signatures
* standart STL containers and Masternode-related classes processing * masternode-related classes * fix st containers processing, use reflection to process simple classes * Content descrioption in README.md * Increase python scripts performance Use gdb objects instead strings and type info for creating Pyton wrappers * fixed simple classes list * addition to README * fix nits * missed `the`
* GCC-7 and glibc-2.27 compat code * Statically link libstdc++ for GCC based builds Makes sure binaries which are built on a newer build host still work on older distros. * Use python3 when installing MacOS native tools * Move actual build logic out of Travis and upgrade to gcc-7 Travis will now simply call a few scripts which do the actual work. These scripts will first create a "builder image" which contains the necessary environment for the actual build. Then scripts are called inside this builder image to do the build. This should make us more independant from Travis and also allows us to do local CI testing. The build matrix is also moved out of .travis.yml and instead moved into ci/matrix.sh. This script is sourced with only "BUILD_TARGET" being set so that it internally can figure out which other environment variables need to be set. This commit also upgrades the used GCC version to 7. This is due to the use of ubuntu:bionic as base image for the builder image. * Add Jenkinsfiles for regular CI and nightly gitian builds * Automatically download OSX SDK in gitian-build.sh * Remove bogus "export MAKEJOBS=-j5" * Forward cache/src dirs into builder container Fixes caching issues on Travis. * fix * Fail build immediately when building depends took too long
* replace boost casts in absolute code Specifically for spork.cpp : this should be temporary until all spork sigs are based on hash and not string serialization format, after which I expect the old signatures (else branch) should go away altogether. But I still think it's worth it to get pieces of the boost dependency removed, and this is an easy win, and could be merged now or in a patch release w/o issue.
> /usr/bin/xcrun -sdk macosx clang -v Apple LLVM version 10.0.0 (clang-1000.11.45.2) Target: x86_64-apple-darwin18.0.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin Before: > XCRUN=`/usr/bin/xcrun -sdk macosx clang -v 2>&1`; echo "$XCRUN" | sed -n 's/.*version \([0-9]\).*/\1/p' 1 After: > XCRUN=`/usr/bin/xcrun -sdk macosx clang -v 2>&1`; echo "$XCRUN" | sed -n 's/.*version \([0-9]*\).*/\1/p' 10
The SporkMessage is a lower-level construct which shouldn't be aware of SporkManager. This commit moves the `sporkManager.IsSporkActive()` calls outside the SporkMessage functions. This follows the dependency injection pattern and makes it easier to test SporkMessage as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest improvements and staging release ready for implementation into the master branch