Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

style(FormattingToolbar): changed order and shortcut for code - I289-290 #294

Merged

Conversation

elit-altum
Copy link
Contributor

Signed-off-by: elit-altum manan.sharma311@gmail.com

Issue #289 #290

Changes

  • Changed the shortcut for code to Ctrl/Cmd+Shift+9
  • Also switched to using Shift instead of in tootips indicating the shortcuts, for improving user readability Change code shortcut #290 (comment)

Screenshot

image

Flags

Related Issues

  • N/A

@elit-altum
Copy link
Contributor Author

@Michael-Grover @irmerk Please review!

jolanglinais
jolanglinais previously approved these changes Mar 14, 2020
Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️ will want a review from @Michael-Grover and @DianaLease

Michael-Grover
Michael-Grover previously approved these changes Mar 16, 2020
Copy link

@Michael-Grover Michael-Grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. This PR made me realize we have no shortcut for "insert a link", which should be ⌘+K, I'll make an issue for that

Signed-off-by: elit-altum <manan.sharma311@gmail.com>
@elit-altum elit-altum dismissed stale reviews from Michael-Grover and jolanglinais via 235f7e6 March 17, 2020 15:43
@elit-altum elit-altum force-pushed the I290-Change-Code-Shrtcut branch from e107073 to 235f7e6 Compare March 17, 2020 15:43
@elit-altum
Copy link
Contributor Author

@irmerk just updated my branch. Can this be merged ?
Thank You!

@jolanglinais jolanglinais merged commit 4acde1d into accordproject:development Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement ✨ Improvement to process or efficiency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change code shortcut Switch order of bulleted list and numbered list icons
3 participants