Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

docs(readme): add keyboard shortcuts - #244 #299

Merged
merged 3 commits into from
Mar 20, 2020
Merged

docs(readme): add keyboard shortcuts - #244 #299

merged 3 commits into from
Mar 20, 2020

Conversation

98lenvi
Copy link
Contributor

@98lenvi 98lenvi commented Mar 17, 2020

Issue #244

Updated readme to show the new keyboard shortcuts

Changes

  • The readme has the following text added just before the ### Demo section

Keyboard shortcuts

The keyboard shortcuts are as follows

Windows/Linux:

  • Common actions

    • CTRL + C - Copy
    • CTRL + X - Cut
    • CTRL + V - Paste
    • CTRL + Z - Undo
    • CTRL + SHIFT + Z - Redo
    • CTRL + Y - Repeat last action

  • Text formatting

    • CTRL + B - Bold
    • CTRL + I - Italicize
    • CTRL + Q - Block quotes
    • CTRL + SHIFT + 9 - Code

  • Paragraph formatting

    • CTRL + SHIFT + 7 - Numbered list
    • CTRL + SHIFT + 8 - Bulleted list

Mac:

  • Common actions

    • ⌘ + C - Copy
    • ⌘ + X - Cut
    • ⌘ + V - Paste
    • ⌘ + Z - Undo
    • ⌘ + SHIFT + Z - Redo
    • ⌘ + Y - Repeat last action

  • Text formatting

    • ⌘ + B - Bold
    • ⌘ + I - Italicize
    • ⌘ + Q - Block quotes
    • ⌘ + SHIFT + 9 - Code

  • Paragraph formatting

    • ⌘ + SHIFT + 7 - Numbered list
    • ⌘ + SHIFT + 8 - Bulleted list

Flags

  • None

Related Issues

@98lenvi
docs(readme): add keyboard shortcuts - #244
14b26c8 
Signed-off-by: lenvi <lenvin@oykuapp.com>
@98lenvi 98lenvi mentioned this pull request Mar 17, 2020
Closed
@jolanglinais jolanglinais added the Type: Documentation 📝 Information and guides for clarification label Mar 17, 2020
@jolanglinais jolanglinais added this to the Keyboard Access milestone Mar 17, 2020
@jolanglinais jolanglinais linked an issue Mar 17, 2020 that may be closed by this pull request
Support keyboard shortcuts #244
Closed
@jolanglinais jolanglinais changed the title Readme : add keyboard shortcuts - #244 docs(readme): add keyboard shortcuts - #244 Mar 17, 2020
jolanglinais
jolanglinais previously approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️ second review please.

DianaLease
DianaLease reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two do not work for me. Is that to be addressed in another PR?
⌘ + Q - Block quotes
⌘ + SHIFT + 9 - Code

@98lenvi
Copy link
Contributor Author

98lenvi commented Mar 18, 2020

In PR #285, the shortcut for blockquotes was changed to CTRL + SHIFT + . , I'll have to update it here

In PR #294, the shortcut for code is changed to CTRL + SHIFT + 9

@elit-altum
Copy link
Contributor

These two do not work for me. Is that to be addressed in another PR?
⌘ + Q - Block quotes
⌘ + SHIFT + 9 - Code

Just checked for the code shortcut. It is working for me.

@jolanglinais
Copy link
Member

These two do not work for me. Is that to be addressed in another PR?
⌘ + Q - Block quotes
⌘ + SHIFT + 9 - Code

Right, block quotes is here: MOD + SHIFT + .

Code shortcut should be working, though...

@jolanglinais
Copy link
Member

Just checked for the code shortcut. It is working for me.

It isn't working for me in the demo, but that's a different issue that can be addressed in a different PR.

Michael-Grover
Michael-Grover previously approved these changes Mar 18, 2020
View reviewed changes
Copy link

@Michael-Grover Michael-Grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@98lenvi
docs(readme): change block quote shortcut - #244
1bb89a4 
Signed-off-by: lenvi <lenvin@oykuapp.com>
@98lenvi 98lenvi dismissed stale reviews from Michael-Grover and jolanglinais via 1bb89a4 March 18, 2020 17:20
@98lenvi
Copy link
Contributor Author

98lenvi commented Mar 18, 2020

Well, I updated the shortcut for the blockquote, by doing so I just pushed a commit and due to a known GitHub bug it looks like I dismissed the reviews(Which I didn't).

@jolanglinais
Copy link
Member

@98lenvi no we have the settings set to dismiss reviews when new commits are pushed.

jolanglinais
jolanglinais suggested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change and we should be good to merge.

README.md Outdated
- `⌘` + `V` - Paste
- `⌘` + `Z` - Undo
- `⌘` + `SHIFT` + `Z` - Redo
- `⌘` + `Y` - Repeat last action
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a current shortcut we are supporting, we can remove it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code snippet shows four shortcuts on my screen, are you referring to just "Repeat last action"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sorry I highlighted line 81 but it shows above that line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it, Please check it now.

@98lenvi
docs(readme): remove Repeat last action shortcut - #244
18efcfd 
Signed-off-by: lenvi <lenvin@oykuapp.com>
jolanglinais
jolanglinais approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@jolanglinais jolanglinais merged commit 61036a2 into accordproject:development Mar 20, 2020
@jolanglinais
Copy link
Member

@98lenvi would you be able to recreate this for master? I'm scrapping the development branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Michael-Grover Michael-Grover Michael-Grover left review comments

@DianaLease DianaLease DianaLease left review comments

@jolanglinais jolanglinais jolanglinais approved these changes

Assignees

@98lenvi 98lenvi

Labels
Type: Documentation 📝 Information and guides for clarification
Projects
None yet
Milestone
Keyboard Access
Development

Successfully merging this pull request may close these issues.

Support keyboard shortcuts
5 participants
@98lenvi @elit-altum @jolanglinais @DianaLease @Michael-Grover