Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

djLint workflow misleading name #1371

Closed
koeaw opened this issue Nov 12, 2024 · 0 comments · Fixed by #1426
Closed

djLint workflow misleading name #1371

koeaw opened this issue Nov 12, 2024 · 0 comments · Fixed by #1426
Labels
tooling Tools, workflows, integrations etc. relevant to project maintenance, deployment, collaboration

Comments

@koeaw
Copy link
Contributor

koeaw commented Nov 12, 2024

The djLint workflow suggests we use it for linting:

apis-core-rdf/.github/workflows/djlint.yml

Line 3 in cfa9006

name: Run djLint Linter

but we're using the default setting of the reusable workflow we're calling, which runs the formatter, so should update its name to accurately describe what it does.

See also acdh-oeaw/prosnet-workflows#84.
@koeaw koeaw added the tooling Tools, workflows, integrations etc. relevant to project maintenance, deployment, collaboration label Nov 12, 2024
@koeaw koeaw mentioned this issue Nov 12, 2024
Open
b1rger added a commit that referenced this issue Nov 21, 2024
@b1rger
ci(djlint): change the name of the workflow to reflect what it does
5ba3892 
The workflow we are including does call djlint with `--check` option,
which checks the formatting of the the template, but does not lint the
template. Therefore using `Formatter` instead of `Linter` in the
template is more correct.

Closes: #1371
@b1rger b1rger mentioned this issue Nov 21, 2024
Merged
@b1rger b1rger closed this as completed in d14e656 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tooling Tools, workflows, integrations etc. relevant to project maintenance, deployment, collaboration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(djlint): change the name of the workflow to reflect what it does acdh-oeaw/apis-core-rdf
1 participant
@koeaw