-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement IdeaVim integration #354
Comments
All right, after merging #353 and reimplementing listeners, I think we have arrived at a solution that restores the functionality which IdeaVim-EasyMotion expects. Although b33ae48 uses The way these changes affect @AlexPl292 should be minimal. The major difference is that AceJump is now Callers who pass an instance of To use AceJump externally, please use the following example: import org.acejump.session.SessionManager
import org.acejump.session.AceJumpListener
import org.acejump.search.Pattern
import org.acejump.boundaries.*
val aceJumpSession = SessionManager.start(editorInstance)
aceJumpSession.addAceJumpListener(object: AceJumpListener {
override fun finished() {
// ...
}
})
// Sessions provide these endpoints for external consumers:
/*1.*/ aceJumpSession.markResults(sortedSetOf(/*...*/)) // Pass a set of offsets
/*2.*/ aceJumpSession.startRegexSearch("[aeiou]+", WHOLE_FILE) // Search for regex
/*3.*/ aceJumpSession.startRegexSearch(Pattern.ALL_WORDS, VISIBLE_ON_SCREEN) // Search for Pattern Unless there are any objections, I am planning to release these changes with @AlexPl292 @chylex Please let me know if you have any questions or concerns. |
I think the use of SearchProcessor is fine, can't think of any issues. Also worth mentioning that custom boundaries for search (i.e. current line before caret etc.) can now be defined in easymotion using the Boundaries interface. |
Yay, glad to see such a big update of AceJump! @chylex great work! 🎉 |
I apologize for the disruption, you can blame me for ruining IdeaVim-EasyMotion and thank @chylex for fixing almost all our outstanding bugs. In the future, I will try to coordinate and communicate breaking changes in a more timely manner. |
Need to reimplement #307 post-refactoring.
The text was updated successfully, but these errors were encountered: