Major refactor & bugfixes #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See acejump#348 for information on what's changed and what more needs to be done.
This was referenced Apr 3, 2021
Merged
Closed
breandan
added a commit
that referenced
this pull request
Apr 4, 2021
This was referenced Apr 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions from #348 and #350. If I recall correctly, the big list of changes covers the first large commit, but the rest of the commits are fairly small targeted changes so it should be clear what they do.
Includes all the commits you wanted except for the removal of tag visiting and option to search the whole file, so those features are still present since they don't conflict with any of the other changes.
I also had to revert your recent change of updating Kotlin to 1.5, for some reason it broke IntelliJ on my end.