Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto switch to Binocular #2916

Closed
Neodyn opened this issue Dec 3, 2015 · 7 comments
Closed

Auto switch to Binocular #2916

Neodyn opened this issue Dec 3, 2015 · 7 comments
Assignees
Labels
Milestone

Comments

@Neodyn
Copy link

Neodyn commented Dec 3, 2015

ACE3 Version: 3.4.0

Mods:
@CBA_A3
@ace

Description:
If you have an Binocular or a Rangefinder in intended slot and exit an car from driverseat the player auto switch to the Binocular or a Rangefinder.

Steps to reproduce:

  • Place a Tank or Car
  • Take a Binocular or a Rangefinder with you
  • get in the car
  • get out of the car
@rebelvg
Copy link
Contributor

rebelvg commented Dec 3, 2015

Yep, can confirm.

@PabstMirror PabstMirror added this to the 3.4.1 milestone Dec 3, 2015
@PabstMirror
Copy link
Contributor

[_unit] call FUNC(binocularMagazine) is called from ace_common_fnc_getAllGear on each frame.

That selectWeapon the binocs and then attempts to switch back, but the _muzzle and _mode are from the car TruckHorn2 so it fails.

I don't think we should be running all that code each frame, maybe we can use weaponsItems.

@commy2 commy2 self-assigned this Dec 3, 2015
@commy2
Copy link
Contributor

commy2 commented Dec 3, 2015

Fix will be done later today.

@PabstMirror
Copy link
Contributor

Fixed by #2935

@OnkelDisMaster
Copy link

Sorry, that I ask about a fixed thing, but I´ve tested #2957 again with the current master. It still doesn´t seem to work.

@PabstMirror
Copy link
Contributor

Fixes are on branch release
https://github.com/acemod/ACE3/tree/release

@OnkelDisMaster
Copy link

Oh, ok thanks and nevermind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants