Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectator public functions are not pre-initialisation safe #5081

Closed
kymckay opened this issue Apr 13, 2017 · 0 comments
Closed

Spectator public functions are not pre-initialisation safe #5081

kymckay opened this issue Apr 13, 2017 · 0 comments
Assignees
@kymckay
Labels
kind/bug
Milestone
3.10.0

Comments

@kymckay
Copy link
Member

kymckay commented Apr 13, 2017

Should be a simple fix, functions updateVisionModes and updateCameraModes are not safe to run before settings have initialised as the GVARs they manipulate are set to defaults upon setting initialisation (overriding any changes applied).

Need to simply use the current system of adding to ace_common_runAtSettingsInitialized if used before ace_common_settingsInitFinished.

Brought to my attention by user anfo in slack 👍
@kymckay kymckay self-assigned this Apr 13, 2017
kymckay added a commit that referenced this issue Apr 15, 2017
@kymckay
Fix #5081
289afe2 
The default values of the arrays manipulated by these functions overwrite
any changes applied before settings have finished initalising. This won't
be an issue after #4456 is merged in future.
@kymckay kymckay mentioned this issue Apr 15, 2017
Merged
@kymckay kymckay added this to the 3.10.0 milestone Apr 29, 2017
kymckay added a commit that referenced this issue May 5, 2017
@kymckay
Fix #5081
6394f2b 
The default values of the arrays manipulated by these functions overwrite
any changes applied before settings have finished initalising. This won't
be an issue after #4456 is merged in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kymckay kymckay

Labels
kind/bug
Projects
None yet
Milestone
3.10.0
Development

No branches or pull requests
1 participant
@kymckay