Convert spectator to CBA settings #4456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also what had me confused while doing this: #4024 (comment) What I expect to happen is: Global settings don't appear in the |
|
@SilentSpike wait for the next CBA. Pabst changed some things around about this. |
|
Tangentially related to this (conversion of the zeus settings), but is there a way to do what we currently do here using the new CBA settings. Keep in mind this is within a module function so multiple instances could run at any point in the mission (i.e. I can't easily add a function to be ran when the setting is changed since each instance of this is associated with an individual logic initialised at an arbitrary time). |
Same implimentation as is used in ACRE for CBA settings. A call to the public API will prevent future changes of the CBA setting from having an effect in order to preserve the intent of the mission maker (possible to have differing setups on different clients, etc.)
This function doubles as a public API and for internal use (when called with no arguments it keeps the list up to date with all the applicable settings).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Believe I've done this correctly, running a function on setting change is a much welcome addition that fits nicely with the way I've structured spectator already.