Common - Add setDead API

[johnb432]

When merged this pull request will:

• Title.
• Added to be used in Vehicle Damage - Fix applying medical damage to non-local and invulnerable units #9988 and other.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[johnb432]

Do we want to add a callable event for this, so that units can be killed from any client?

[PabstMirror]

in ace_medical_statemachine_fnc_enteredStateDeath

we could add
private _source = _unit getVariable [QEGVAR(medical,lastDamageSource), objNull];
and change to
[_unit, _causeOfDeath, _source, _instigator] call EFUNC(medical_status,setDead);

should give us a more accurate killed EH, but I'm not sure what side effects it might have
or why we didn't do it originally

[PabstMirror]

maybe merge now and I can do that in a followup

[BrettMayson]

Add an event at the same time?

[LinkIsGrim]

ace_killed should already fire, unless you mean event to kill remote units

[BrettMayson]

That only fires with medical enabled right? And it also won't include the reason string

[johnb432]

That only fires with medical enabled right? And it also won't include the reason string

ace_killed is indeed part of medical_status, but it includes the reason string (it's the 2nd param of ace_killed). It's raised automatically as the unit is killed, so there is no need to raise any events for when ace_medical is loaded.

I'm not sure if we want to add events when ace_medical isn't loaded. We could reuse ace_killed, but I'm not sure if that's a good idea. If a mod doesn't use ace_medical, it has to rely on the Vanilla Killed EH, meaning it could also have its own way of handling reasons of death.

I added the reason as a param for when ace_medical is loaded, I didn't intend it to be used when it wasn't loaded, as I don't see the point of using a reason when not using ace_medical.

[johnb432]

We can add events in another PR if it's necessary.