Kill Tracker - Add setting to show kills from vehicle to crew #10069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkIsGrim
approved these changes
Jun 14, 2024
PabstMirror
commented
Jun 16, 2024
| private _instigator = _unit getVariable [QEGVAR(medical,lastInstigator), objNull]; | ||
|
|
||
| [_unit, _causeOfDeath, _instigator] call EFUNC(medical_status,setDead); | ||
| [_unit, _causeOfDeath, _source, _instigator] call EFUNC(medical_status,setDead); |
There was a problem hiding this comment.
this change effects more than killtracker,
vanilla killed EH will also have correct killer/instigator now as well
I don't expect it to cause any problems, but it's something to remember
johnb432
reviewed
Jun 16, 2024
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
johnb432
approved these changes
Jun 16, 2024
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
…#10069) * Kill Tracker - Add setting to show kills from vehicle to crew * Update addons/killtracker/XEH_postInit.sqf Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> --------- Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #10045 (comment)
before this, kills would usually go to the driver of a vehicle, not the trigger puller
so this setting attempts to mimic and expand that behavior