Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General - Use variable for checking if medical is enabled #10063

Merged
merged 4 commits into from
Jun 18, 2024
Merged

General - Use variable for checking if medical is enabled #10063

merged 4 commits into from
Jun 18, 2024

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror PabstMirror added this to the 3.18.0 milestone Jun 11, 2024
@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Jun 11, 2024
johnb432
johnb432 approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to apply the changes proposed in #10073 where necessary, but otherwise LGTM.

@LinkIsGrim LinkIsGrim enabled auto-merge (squash) June 18, 2024 00:06
@LinkIsGrim LinkIsGrim merged commit 95b7951 into master Jun 18, 2024
3 of 5 checks passed
@johnb432 johnb432 deleted the general-move-medical-check branch June 18, 2024 07:43
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@LinkIsGrim @blake8090
General - Use variable for checking if medical is enabled (acemod#10063)
29636b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LinkIsGrim @PabstMirror @johnb432