Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Add ace_medical_enabled variable for future-proofing API #9996

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Add a variable for 3rd party to check against for medical's overall enabled status. Hard set here, switch to setting when we implement it.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/change Release Notes: **CHANGED:** label Apr 29, 2024
@LinkIsGrim LinkIsGrim added this to the 3.17.1 milestone Apr 29, 2024
@johnb432
Copy link
Contributor

I'm a bit confused as to why you want to add this now, especially as atm it's not looking bright for #9593.
I'm just not sure if it will ever be a setting, given that the requests we've made to BI to make it work as a setting have been ignored.

@jonpas jonpas modified the milestones: 3.17.1, 3.18.0 Apr 29, 2024
@jonpas
Copy link
Member

jonpas commented Apr 29, 2024

Definitely not 3.17.1.

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@LinkIsGrim LinkIsGrim merged commit 2bd1f39 into master Jun 11, 2024
5 checks passed
@LinkIsGrim
Copy link
Contributor Author

Should followup by making everything else check for this as well.

@LinkIsGrim LinkIsGrim deleted the medical-api-enable branch June 11, 2024 14:46
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
…cemod#9996)

* add ace_medical_enabled setting

* Update addons/medical_engine/XEH_preInit.sqf

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>

---------

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/change Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants