Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interact Menu - Fix self actions when handcuffed #10188

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

PabstMirror
Copy link
Contributor

ref #10187

@PabstMirror
Copy link
Contributor Author

Can anyone think of issues this might cause?
I'm worried this might have negative side-effects

Should we only allow self interactions when handcuffed?

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Aug 11, 2024

As long as exception handling doesn't break this should be fine I think. Exceptions need to be explicit anyway so there shouldn't be anything in ACE3 or addon mods that will be made possible with this that wasn't before (besides the fix).

@PabstMirror PabstMirror marked this pull request as ready for review August 11, 2024 20:36
@PabstMirror PabstMirror added this to the 3.18.0 milestone Aug 11, 2024
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Aug 11, 2024
@johnb432 johnb432 linked an issue Aug 13, 2024 that may be closed by this pull request
@johnb432 johnb432 merged commit b96d74f into master Aug 13, 2024
5 checks passed
@johnb432 johnb432 deleted the handcuffActions branch August 13, 2024 09:19
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Self-Interaction possible while Handcuffed, despite Exception
3 participants