Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Allow custom event name for status effects #10473

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

PabstMirror
Copy link
Contributor

Alt to #10468

Allows custom event names for status effects
Switch to hashmap

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Dart <59131299+DartRuffian@users.noreply.github.com>
@PabstMirror PabstMirror added this to the 3.18.2 milestone Nov 10, 2024
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Nov 10, 2024
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, but logic seems good to me.

@johnb432 johnb432 merged commit 9bca2a7 into master Nov 16, 2024
3 checks passed
@johnb432 johnb432 deleted the effectHash branch November 16, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants