Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Throwing - Cleanup #10495

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Advanced Throwing - Cleanup #10495

merged 4 commits into from
Nov 22, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Nov 9, 2024

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/cleanup Release Notes: **CHANGED:** label Nov 9, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Nov 9, 2024
@PabstMirror
Copy link
Contributor

noticed some weirdness with selecting grenades by hitting shift-g multiple times
but it seems to be fixed by #9488 (see note) and is probably unrelated to this PR

private _nonInheritedCfg = configProperties [configFile >> "CfgAmmo" >> _throwableType, 'configName _x == QGVAR(replaceWith)', false];
if ((count _nonInheritedCfg) == 1) then {
_throwableType = getText (_nonInheritedCfg select 0);
if (inheritsFrom (_ammoConfig >> QGVAR(replaceWith)) isEqualTo _ammoConfig) then {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi QGVAR(replaceWith) isn't actually used anywhere, but I'm keeping it for BWC, despite it not being documented.

@johnb432 johnb432 merged commit defbf33 into master Nov 22, 2024
3 checks passed
@johnb432 johnb432 deleted the adv-throw-cleanup branch November 22, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants