Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical - Add API for fully healing a unit #10498

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Medical - Add API for fully healing a unit #10498

merged 9 commits into from
Nov 21, 2024
+36 −2

Conversation

DartRuffian
Copy link
Contributor

@DartRuffian DartRuffian commented Nov 10, 2024 •
edited
Loading

When merged this pull request will:

  • Add a public API function to full heal a unit
    • This is just a wrapper with some param checking
  • Add optional parameter to medical_treatment_fnc_fullHeal to not add the full heal log message

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@DartRuffian DartRuffian changed the title Medical - Add API for full healing a unit Medical - Add API for fully healing a unit Nov 10, 2024
DartRuffian and others added 2 commits November 10, 2024 13:18
@DartRuffian @LinkIsGrim
Use patient as medic if not passed
6a76462 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@DartRuffian
Update function header
ee70a64
@DartRuffian
Copy link
Contributor Author

DartRuffian commented Nov 10, 2024 •
edited
Loading

Thought about adding a boolean flag to medical_treatment_fnc_fullHeal to enable/disable the full heal message that shows in the medical GUI. Should that be a separate PR after this or just do it in one?

Figured I'd just include what I meant, commit can just be reverted if it should be a separate PR

@PabstMirror PabstMirror added this to the 3.18.2 milestone Nov 10, 2024
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Nov 10, 2024
DartRuffian and others added 2 commits November 10, 2024 18:44
@DartRuffian @LinkIsGrim
Update function header
0ea54f6 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@DartRuffian @LinkIsGrim
Update function header
a508098 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
BaerMitUmlaut
BaerMitUmlaut previously requested changes Nov 13, 2024
View reviewed changes
addons/medical_treatment/functions/fnc_fullHeal.sqf Outdated Show resolved Hide resolved
addons/medical/functions/fnc_fullHeal.sqf Outdated Show resolved Hide resolved
addons/medical/functions/fnc_fullHeal.sqf Outdated Show resolved Hide resolved
@PabstMirror PabstMirror merged commit d666149 into acemod:master Nov 21, 2024
3 checks passed
@DartRuffian DartRuffian deleted the medica/full-heal-api branch November 21, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@johnb432 johnb432 johnb432 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

@BaerMitUmlaut BaerMitUmlaut Awaiting requested review from BaerMitUmlaut

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
5 participants
@DartRuffian @PabstMirror @BaerMitUmlaut @johnb432 @LinkIsGrim