Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nozzle additonal check condition #2954

Merged
merged 2 commits into from
Feb 17, 2016
Merged

Conversation

gienkov
Copy link
Contributor

@gienkov gienkov commented Dec 6, 2015

Have you ever did refuel at gas station with engine on?

@commy2
Copy link
Contributor

commy2 commented Dec 6, 2015

Yes, I have. : - )

@jokoho48
Copy link
Member

jokoho48 commented Dec 6, 2015

@commy2 bad idea :D
i like the idea 👍

@VKing6
Copy link
Member

VKing6 commented Dec 6, 2015

Not sure that idea applies to tanks.
They wouldn't drive up to the refuel bowser and turn their engines off just for the few minutes it takes to refuel.

@gienkov
Copy link
Contributor Author

gienkov commented Dec 6, 2015

@VKing6 you can still start up tank engine within seconds in Arma so...

@kymckay
Copy link
Member

kymckay commented Dec 6, 2015

Isn't this invalid syntax?

@gienkov
Copy link
Contributor Author

gienkov commented Dec 6, 2015

I'm gonna test but I used wiki https://community.bistudio.com/wiki/isEngineOn

@kymckay
Copy link
Member

kymckay commented Dec 6, 2015

I mean because the condition is using lazy evaluation and you've added a non-lazy condition onto the end

@gienkov
Copy link
Contributor Author

gienkov commented Dec 6, 2015

Um... tell me how to fix? :)

@kymckay
Copy link
Member

kymckay commented Dec 6, 2015

I'd add a line under 24 with:

{isEngineOn _target} ||

@thojkooi thojkooi added kind/enhancement Release Notes: **IMPROVED:** kind/feature Release Notes: **ADDED:** labels Dec 10, 2015
@thojkooi thojkooi added this to the 3.5.0 milestone Dec 10, 2015
@nicolasbadano
Copy link
Contributor

In any case the lazy evaluation thing should be fixed @gienkov

@gienkov
Copy link
Contributor Author

gienkov commented Feb 9, 2016

Fixed!

@bux
Copy link
Member

bux commented Feb 9, 2016

👍

thojkooi added a commit that referenced this pull request Feb 17, 2016
nozzle additonal check condition
@thojkooi thojkooi merged commit a8846e9 into acemod:master Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants