Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow refueling with running engine #3534

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

GitHawk
Copy link
Contributor

@GitHawk GitHawk commented Mar 4, 2016

Extending #2954 by disallowing refueling with a running engine in both canTurnOn and the refuel PFH

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Mar 4, 2016
@jonpas jonpas added this to the 3.5.1 milestone Mar 4, 2016
@nicolasbadano nicolasbadano added kind/bug-fix Release Notes: **FIXED:** and removed kind/enhancement Release Notes: **IMPROVED:** labels Mar 7, 2016
thojkooi added a commit that referenced this pull request Mar 8, 2016
Disallow refueling with running engine
@thojkooi thojkooi merged commit ddd8187 into acemod:master Mar 8, 2016
@bux
Copy link
Member

bux commented Mar 9, 2016

@GitHawk I had a talk about that with a Bundeswehr soldier. The bigger German vehicles all have to have their engine running for refueling. Maybe it might be better to check for civilian cars / light cars to have their engine off?

@GitHawk
Copy link
Contributor Author

GitHawk commented Mar 9, 2016

I just want to avoid collisions between increasing the amount and ArmA decreasing it.

@nicolasbadano
Copy link
Contributor

I just want to avoid collisions between increasing the amount and ArmA decreasing it.

That shouldn't be a concern given how slowly fuel is consumed.

@GitHawk
Copy link
Contributor Author

GitHawk commented Mar 10, 2016

I personally don't care. I can remove all checks if you like @bux578 @esteldunedain

Technically you can refuel a real car/truck/tank with a running engine.
At civil fuel stations it is frowned upon (in some places maybe even illegal) to have the engine running while refueling.

@GitHawk GitHawk deleted the refuel_isEngineOn branch March 10, 2016 10:20
@Khaosmatic
Copy link

You should make it so if the engine is left on it explodes with a megaton blast radius. Dat'll teech dem kids.

@sargken
Copy link
Contributor

sargken commented Mar 10, 2016

You should make it a random chance that it would catch fire or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants