Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair & medical object attributes for eden editor #3288

Merged
merged 3 commits into from
Feb 19, 2016
Merged

Repair & medical object attributes for eden editor #3288

merged 3 commits into from
Feb 19, 2016

Conversation

SzwedzikPL
Copy link
Contributor

@jokoho48 jokoho48 added kind/enhancement Release Notes: **IMPROVED:** kind/feature Release Notes: **ADDED:** 1.56 labels Feb 7, 2016
@jokoho48
Copy link
Member

jokoho48 commented Feb 7, 2016

👍

@jonpas
Copy link
Member

jonpas commented Feb 7, 2016

Should we use a tag in those settings to set them apart from vanilla ones and make it clear it's an ACE setting? Eg. [ACE] Is Medic

<Polish>Wyszkolenie medyczne</Polish>
</Key>
<Key ID="STR_ACE_Medical_Attributes_isMedicalVehicle_Description">
<English>Whatever or not the objects will be a medical vehicle.</English>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably meant to be Whether and object.

@Daishiknyte
Copy link

Jonpas is correct. Any added commands, menus, etc., should clearly show the mod they're associated with.

@nicolasbadano
Copy link
Contributor

👍 Nice. I agree that some indication that those settings are ace would be great. Maybe:
ACE: Is Medic:

@kymckay
Copy link
Member

kymckay commented Feb 8, 2016

I feel like having categories for ace attributes would make more sense than using the special states category. Also eliminates the need to repetitively label each attribute with ace in the name.

@commy2
Copy link
Contributor

commy2 commented Feb 8, 2016

^ this

class AttributeCategories {
class StateSpecial {
class Attributes {
class ACE_IsMedic {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lower case is

@SzwedzikPL
Copy link
Contributor Author

I've added ace category and used common_Options stringtable

http://i.imgur.com/Z1tI6b3.jpg //units
http://i.imgur.com/KRwpL0Y.jpg //vehicles
http://i.imgur.com/CNoeQJe.jpg //props

@gienkov
Copy link
Contributor

gienkov commented Feb 10, 2016

👍
10.02.2016 01:18 "SzwedzikPL" notifications@github.com napisał(a):

I've added ace category and used common_Options stringtable

http://i.imgur.com/Z1tI6b3.jpg //units
http://i.imgur.com/KRwpL0Y.jpg //vehicles
http://i.imgur.com/CNoeQJe.jpg //props


Reply to this email directly or view it on GitHub
#3288 (comment).

@nicolasbadano
Copy link
Contributor

Looks good @SzwedzikPL

@nicolasbadano nicolasbadano added this to the 3.5.0 milestone Feb 18, 2016
@nicolasbadano
Copy link
Contributor

👍 For merging this for 3.5.0

commy2 added a commit that referenced this pull request Feb 19, 2016
Repair & medical object attributes for eden editor
@commy2 commy2 merged commit 5d0d857 into acemod:master Feb 19, 2016
@SzwedzikPL SzwedzikPL deleted the edenassignsettings branch February 19, 2016 11:25
@PabstMirror
Copy link
Contributor

@SzwedzikPL
These do not work in MP, only the server has the correct settings.

        class AttributesBase {
            class Default {
                expression = "_this setVariable ['%%s',_value,true];";
            };

The default uses the broadcast flag whereas these do not.
We might want to just use inheritance instead of redefining expression.
As far as I can tell only the server executes the code.

Also see notes in #3339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants