-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair & medical object attributes for eden editor #3288
Conversation
👍 |
Should we use a tag in those settings to set them apart from vanilla ones and make it clear it's an ACE setting? Eg. |
<Polish>Wyszkolenie medyczne</Polish> | ||
</Key> | ||
<Key ID="STR_ACE_Medical_Attributes_isMedicalVehicle_Description"> | ||
<English>Whatever or not the objects will be a medical vehicle.</English> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably meant to be Whether
and object
.
Jonpas is correct. Any added commands, menus, etc., should clearly show the mod they're associated with. |
👍 Nice. I agree that some indication that those settings are ace would be great. Maybe: |
I feel like having categories for ace attributes would make more sense than using the special states category. Also eliminates the need to repetitively label each attribute with ace in the name. |
^ this |
class AttributeCategories { | ||
class StateSpecial { | ||
class Attributes { | ||
class ACE_IsMedic { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lower case is
I've added ace category and used common_Options stringtable http://i.imgur.com/Z1tI6b3.jpg //units |
👍
|
Looks good @SzwedzikPL |
👍 For merging this for 3.5.0 |
Repair & medical object attributes for eden editor
@SzwedzikPL
The default uses the broadcast flag whereas these do not. Also see notes in #3339 |
http://i.imgur.com/LXfNjDB.jpg //units
http://i.imgur.com/ad0qBLq.jpg //vehicles
http://i.imgur.com/j6S7Tmo.jpg //props