Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'name' to components #3955

Merged
merged 8 commits into from
Jun 20, 2016
Merged

add 'name' to components #3955

merged 8 commits into from
Jun 20, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jun 19, 2016

When merged this pull request will:

  • adds 'name' to all components by macros
  • fixes some indentation issues and uses ADDON macro in parachute

@commy2 commy2 added the kind/enhancement Release Notes: **IMPROVED:** label Jun 19, 2016
@commy2 commy2 added this to the 3.6.0 milestone Jun 19, 2016
@thojkooi
Copy link
Contributor

What is the purpose of the name attribute in CfgPatches? Is this a new BI thing?

@SzwedzikPL
Copy link
Contributor

What is the purpose of the name attribute in CfgPatches? Is this a new BI thing?

Yes. Name from CfgPatches is displayed in required addons list in eden

@commy2
Copy link
Contributor Author

commy2 commented Jun 19, 2016

And this patch will change "ace_gforces" to "Advanced Combat Environment 3 - gforces"

@bux
Copy link
Member

bux commented Jun 19, 2016

I don't like the long name. ACE3 is sufficient. And name should contain the file name of the pbo.

@commy2
Copy link
Contributor Author

commy2 commented Jun 19, 2016

There is enough space for that name. Vanilla Arma has even longer ones.

And name should contain the file name of the pbo.

You already get the name of pbo if you select the "advanced" tab. This screen is for end users.

@commy2
Copy link
Contributor Author

commy2 commented Jun 19, 2016

Arma 3 Marksmen (Multiplayer) - Mission Texts and Translations
vs.
Advanced Combat Environment 3 - spottingscope

@bux
Copy link
Member

bux commented Jun 19, 2016

This screen is for end users.

Exactly.

"ACE3" is more common. And it's the end user that deletes random pbo's. So giving them the info what pbo they require would be helpful.

@commy2
Copy link
Contributor Author

commy2 commented Jun 19, 2016

Yeah.
I wouldn't use the raw pbo name though. That's what you get in the "advanced" tab already. It would defeat the purpose of this system.

@jonpas
Copy link
Member

jonpas commented Jun 19, 2016

I vote ACE3 - component as well.

Would be great if we could prettify components but that's some work I guess. :D

@commy2
Copy link
Contributor Author

commy2 commented Jun 20, 2016

Thanks for the help, guys. 👍

@commy2 commy2 self-assigned this Jun 20, 2016
@commy2
Copy link
Contributor Author

commy2 commented Jun 20, 2016

merging, sue me

@commy2 commy2 merged commit 3fdc0dd into master Jun 20, 2016
@commy2 commy2 deleted the add_name branch June 20, 2016 17:26
@bux
Copy link
Member

bux commented Jun 20, 2016

sues commy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants