Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chinese content & missing string #5375

Merged
merged 6 commits into from
Jul 19, 2017
Merged

Fix Chinese content & missing string #5375

merged 6 commits into from
Jul 19, 2017

Conversation

Topbcy
Copy link

@Topbcy Topbcy commented Jul 19, 2017

Fix some Chinese punctuation & content, add new string with compact_adr97.

@@ -15,6 +15,8 @@
<Japanese>P90 TR (黒)</Japanese>
<TChinese>P90 TR (黑色)</TChinese>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonpas didn't you replace all stringtable entries?

Copy link
Member

@jonpas jonpas Jul 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, maybe the compats were missed. :/

@Dissyu Those are already translated yeah, just their string tag is wrong TChinese/SChinese instead of Chinese/Chinesesimp because I forgot to change those on optionals... My bad.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already fix~~~ @jonpas Thanks you remind me~~

@jonpas jonpas added this to the 3.11.0 milestone Jul 19, 2017
@jonpas jonpas added the kind/translation Release Notes: **TRANSLATIONS:** label Jul 19, 2017
@Topbcy
Copy link
Author

Topbcy commented Jul 19, 2017

Remove adr97 unnecessary string, this time might cleaner

@jonpas
Copy link
Member

jonpas commented Jul 19, 2017

Are you and @GodofMonkeys working together or would you prefer you look at each other's changes before we merge them?

@Topbcy
Copy link
Author

Topbcy commented Jul 19, 2017

@jonpas ok, we merge together.

@jonpas
Copy link
Member

jonpas commented Jul 19, 2017

Not what I meant, was just asking. We can merge them separately. I was just asking in case you don't agree on some translations.

@GodofMonkeys
Copy link
Contributor

@jonpas That's ok, we compare it, don't have any conflict with any string. It is good to go :)

@jonpas jonpas merged commit a795436 into acemod:master Jul 19, 2017
@jonpas
Copy link
Member

jonpas commented Jul 19, 2017

Awesome! Keep them coming. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants