-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Chinese content & missing string #5375
Conversation
Fix Advanced Fatigue & QuickMount
@@ -15,6 +15,8 @@ | |||
<Japanese>P90 TR (黒)</Japanese> | |||
<TChinese>P90 TR (黑色)</TChinese> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonpas didn't you replace all stringtable entries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, maybe the compats were missed. :/
@Dissyu Those are already translated yeah, just their string tag is wrong TChinese/SChinese
instead of Chinese/Chinesesimp
because I forgot to change those on optionals... My bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already fix~~~ @jonpas Thanks you remind me~~
Remove adr97 unnecessary string, this time might cleaner |
Are you and @GodofMonkeys working together or would you prefer you look at each other's changes before we merge them? |
Fix missing string
@jonpas ok, we merge together. |
Not what I meant, was just asking. We can merge them separately. I was just asking in case you don't agree on some translations. |
@jonpas That's ok, we compare it, don't have any conflict with any string. It is good to go :) |
Awesome! Keep them coming. ;) |
Fix some Chinese punctuation & content, add new string with compact_adr97.