Add CBA setting for noRadio #5571
Conversation
|
Just curious, why is the DC event handler added, even if the module is disabled? It's not going to fire a lot, but I'm always a fan of not adding handlers if the component is disabled. |
|
To support changing it on the fly. More and more things that don't it like that will likely be converted as we start manually moving components to CBA Settings. It's not any overhead really on an event handler like that. For things that execute more often it might be wiser to add/remove handler as required. |
|
@jonpas the main player changed EH won't get added if it's changed on the fly. I guess I don't see how handling these two items separately will add anything (besides confusion ;) ) I'm not sure how ACE will convert to CBA settings, but (as you know) CBA settings can have a chunk of code executed on change, which should allow adding/removing these kinds of event handlers without too much pain (only problem will probably come from handling class event handlers, and the messiness of having to track the EHIDs through GVARs). |
|
Ah I didn't notice that, good point! And yes, that's why I said it will probably only be used for performance heavy EHs. We'll see how we'll pursue that, for starters ACE Settings will be converted on the fly to CBA Settings, there will definitely be a post going live with the update about that. |
|
I'd like to make this the first CBA setting and have it support changing it on the fly :) |
|
I think we can pick this up for 3.12 |
* Add ace_setting for noRadio * Delay adding server EH * make noradio a cba setting
Close #2346