Quick Mount - Add Get In and Change seat action menu #5745

Dystopian · 2017-11-12T02:49:09Z

When merged this pull request will:

add menu to take any seat in vehicle including any passenger seat;
add menu to change seat inside vehicle respecting game config values for that.

I think this menu is perfect continuation of Quick Mount component. Also it can be used to work around vanilla bug when you can change seat from passenger to driver but not in reverse order (e.g. in vanilla offroad). And it's always nice to change passenger seat closer or farther to window, to enjoy nature view or hide from bullets.

Icons are not ideal but really cute.

Unfortunately MoveTo* actions (which are intended for seat changing) don't work correctly when there is somebody else in vehicle (even AI). So for Change seat menu I had to use moveOut + moveIn* commands. Side effects: GetIn and GetOut EH on each seat change, dead bodies are ejected from their seats. But I don't think it's a big deal.

Things to discuss:

delete menu for static turrets?
change menu priority to pull it down?
describe in code how the game handles config values to manage To Smbdy seat actions displaying?
I don't really know if isTurnedOut command should be used to restrict menu. On one hand vanilla actions are disabled when you're turned out, on other hand we already break vanilla rules for taking seat with Quick Mount.

jonpas · 2017-11-12T02:53:25Z

I like this overall, however I think we should respect compartment config of the vehicle. In some vehicles you are not able to realistically move from some seat to another, eg. front of truck to the back (let's ignore people who want to fall off).
I see it already does that, my bad, commented before I checked the code! :)

Maybe add a setting to disable that sub-menu for people who don't want extra options they might not use?

Dystopian · 2017-11-12T03:23:41Z

CI tools fail because of multi-line macro.

I don't really like additional setting idea (besides implemented ace_quickmount_enabled outside of vehicle), but if you insist, I'll add it.

commy2 · 2017-11-12T09:45:38Z

Remove the ; from the last line of the macro and add it after GETIN_ACTIONS (GETIN_ACTIONS;).

Dystopian · 2017-11-12T11:28:16Z

@commy2 is it for config style or to workaround sqf validator issue? If first - there also similar configs in other components, if last - it's not about config but about macro in sqf.

commy2 · 2017-11-12T13:27:27Z

All lines should end with ;
Even if they use a macro.
The macro itself isn't supposed to end with ;

commy2 · 2017-11-12T17:17:21Z

See? And now Travis is happy.

Dystopian · 2017-11-12T17:20:09Z

travis was already happy after 8af3296 :P

Dystopian · 2017-11-26T01:38:21Z

will add setting to disable menu and workaround for seat changing while land vehicle is moving fast (atm unit gets damage).

Dystopian · 2017-12-26T23:14:58Z

can't fix CI fails due to #5979 :(

Dystopian · 2017-12-30T21:07:14Z

Did you know that unit can't get in flipped vehicle even with moveIn* commands? That's bad news for Change seat feature :( I have to search for workaround.

PabstMirror · 2018-01-01T04:10:06Z

I'd really rather use the action ["moveTo commands if possible.

With a player in the vic they seemed to work just fine, I only had a problem when a AI was in driver's seat. But the vanilla switch actions didn't show on the action menu either.

Maybe we can determine the canShow condition logic and replicate.

dedmen

Would approve. But I'm not as I'm not concentrated enough to spot every problem now.
Looks good overall.

dedmen · 2018-10-14T13:19:05Z

addons/quickmount/functions/fnc_addFreeSeatsActions.sqf

+ * Public: No
+ */
+
+#define TO_STRING(var) if !(var isEqualType "") then {var = format [ARR_2("Compartment%1",var)]}


maybe call it TO_COMPARTMENT_STRING. As this is specialized.

dedmen · 2018-10-14T13:20:07Z

addons/quickmount/functions/fnc_addFreeSeatsActions.sqf

+    _cargoCompartments = getArray (_vehicleConfig >> "cargoCompartments");
+    {
+        if !(_x isEqualType "") then {
+            _cargoCompartments set [_forEachIndex, format ["Compartment%1", _x]];


use apply
Also you made a macro for this. Why don't you use it now?

Look how it was with apply: 9e17c18#diff-ded96a376761ae515c888f369fb06b23R55
I changed it to forEach only last days because IMHO it looks better and clearer.

Macro sets variable not array member so I can't use it here.

_cargoCompartments = _cargoCompartments apply {[format ["Compartment%1", _x], -x] select (_x isEqualType "")}

will test in a week

apply is slower (even without intermediate cargoCompartments assignment) and less clear ✋

Don't understand how it can be. If you are doing the same thing, but with less commands and less variables (forEachIndex) it shouldn't possibly be slower.

Edit: Ah understood now.

If you are doing the same thing

yeah they aren't. My variant copies _x if it's already a string. Yours just does nothing.

Do you have an example vehicle where cargoCompartments isn't actually an array of strings?
Oh okey. Compartment1 is actually a enum that evaluates to 1.
Compartment2 = 2
Compartment3 = 4
Compartment4 = 8 and so on.. Meh.

0.0083 ms

private _cargoCompartments = getArray (configFile >> "CfgVehicles" >> typeOf cursorobject >> "cargoCompartments"); { if !(_x isEqualType "") then { _cargoCompartments set [_forEachIndex, format ["Compartment%1", _x]]; }; } forEach _cargoCompartments; _cargoCompartments

vs
0.0108 ms

private _cargoCompartments = getArray (configFile >> "CfgVehicles" >> typeOf cursorobject >> "cargoCompartments") apply {[format ["Compartment%1", _x], _x] select (_x isEqualType "")}; _cargoCompartments

when cursorObject is I_Truck_02_covered_F

@dedmen when you edit your message nobody gets notification unlike when you create message (maybe in github desktop?). I really accidentally found your question.

Do you have an example vehicle where cargoCompartments isn't actually an array of strings?

CUP_Ural_ZU23_Base, rhs_truck, rhsusf_fmtv_base and some more RHS vehicles. No in vanilla.

Well I expected you read the message on github. Instead of in a notification E-Mail or wherever.

dedmen · 2018-10-14T13:21:00Z

addons/quickmount/functions/fnc_addFreeSeatsActions.sqf

+
+    // find current compartment
+    (
+        _fullCrew select (_fullCrew findIf {_player == _x select 0})


this will error if player is not in crew. Are you sure he is?

yes, if (_isInVehicle) then { ^^ L88

Dystopian · 2018-10-23T22:39:15Z

Found small bug with some ~~RHS~~ vehicles. Will investigate.
~~RHS~~ 😠

PabstMirror · 2018-10-30T05:05:44Z

addons/quickmount/functions/fnc_addFreeSeatsActions.sqf

+// workaround getting damage when moveout while vehicle is moving
+#define MOVEOUT_AND_BLOCK_DAMAGE \
+    if (isDamageAllowed _player) then { \
+        _player allowDamage false; \


Might want to use
[_player, "blockDamage", QUOTE(ADDON), true] call EFUNC(common,statusEffect_set);

EFUNC(common,statusEffect_set) would set global variable twice in 1 second. I don't think it's worth it to use it just for 1 second allowDamage.

addons/quickmount/functions/fnc_canShowFreeSeats.sqf

Dystopian · 2018-11-05T22:22:11Z

Added workaround for changing seat to FFV turret with enabledByAnimationSource. This is Arma bug not RHS.

commy2 · 2018-11-05T23:19:51Z

It's been a year. I feel bad for Dystopian.

PabstMirror · 2018-11-11T18:14:25Z

With CH-47 in flight, switching to rear gunner seats causes me to enter standing float animation (if ramp is closed)

Eliminating the delay }, _this, DISABLED_FFV_TIMEOUT] call CBA_fnc_waitAndExecute; seems to fix, but it sounds like that's needed for something else

Dystopian · 2018-11-15T21:22:27Z

Bugged FFV seats are disabled.
Also fixed bug with local turrets in non-local vehicle.

jonpas · 2018-11-18T20:05:34Z

@PabstMirror should review before merge as well.

* Add quickmount GetIn menu * Add compartment support * Check engine, check pilot, check static turret driver * Add doc, condition, translation * Add hybrid config entries, fix MP issue * Optimize condition * Ignore Enabled setting in vehicle * Work around SQF validator macro issue * Fix config macro entries * Add workaround for getting damage when seat changing while moving * Add setting for Get In menu disabling * Fix race when 2 players try to get the same seat * Convert if-else to switch * Decrease move-back timeout to 0.5s * Check if vehicle is flipped * Add getin statement for parent menu * Improve canShowFreeSeats * Apply latest trends * Improve fnc_addFreeSeatsActions * Change copilot and gunless turret icons * Fix macro name * Fix FFV icon * Optimize turret icon code * Extend setting to 4 values * Fix menu is shown when vehicle is full * Optimize UAV checking code * Fix bug with disabled FFV turrets * Remove bugged FFV, Add turret locality check, Add Failed message * Replace some macros with function * Fix validator * Remove global variables, Add debug

Dystopian added 7 commits November 6, 2017 03:05

Add quickmount GetIn menu

c1b9ec8

Add compartment support

39c9c8b

Check engine, check pilot, check static turret driver

9e73ca8

Add doc, condition, translation

0222463

Add hybrid config entries, fix MP issue

9e17c18

Optimize condition

414d00e

Ignore Enabled setting in vehicle

5316536

jonpas added the kind/feature Release Notes: **ADDED:** label Nov 12, 2017

jonpas added this to the 3.13.0 milestone Nov 12, 2017

jonpas added the status/review-pending label Nov 12, 2017

Work around SQF validator macro issue

8af3296

Fix config macro entries

3e3993a

Dystopian added 7 commits November 26, 2017 23:27

Add workaround for getting damage when seat changing while moving

02d5a69

Merge remote-tracking branch 'upstream/master' into getin_menu

3b0d540

Add setting for Get In menu disabling

17ca955

Merge branch 'master' into getin_menu

7eccae8

Fix race when 2 players try to get the same seat

a66d97e

Convert if-else to switch

81f711d

Decrease move-back timeout to 0.5s

6cc77b8

Change copilot and gunless turret icons

0e439af

dedmen reviewed Oct 14, 2018

View reviewed changes

Dystopian added 3 commits October 14, 2018 16:53

Fix macro name

8d59c9e

Fix FFV icon

5a02381

Optimize turret icon code

283fae0

PabstMirror reviewed Oct 30, 2018

View reviewed changes

addons/quickmount/functions/fnc_canShowFreeSeats.sqf Outdated Show resolved Hide resolved

Dystopian added 4 commits October 31, 2018 01:19

Extend setting to 4 values

fb01018

Fix menu is shown when vehicle is full

5856d7b

Optimize UAV checking code

09356d6

Fix bug with disabled FFV turrets

493e5b3

PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 10, 2018

Dystopian added 4 commits November 11, 2018 23:12

Merge remote-tracking branch 'upstream/master' into getin_menu

59a97df

Remove bugged FFV, Add turret locality check, Add Failed message

32e8e5d

Replace some macros with function

274ef00

Fix validator

66b661d

jonpas approved these changes Nov 18, 2018

View reviewed changes

Remove global variables, Add debug

ef3cc84

PabstMirror removed the status/review-pending label Nov 19, 2018

PabstMirror approved these changes Nov 19, 2018

View reviewed changes

PabstMirror merged commit e8c3be8 into acemod:master Nov 19, 2018

Dystopian deleted the getin_menu branch November 19, 2018 05:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quick Mount - Add Get In and Change seat action menu #5745

Quick Mount - Add Get In and Change seat action menu #5745

Dystopian commented Nov 12, 2017

jonpas commented Nov 12, 2017 •

edited

Loading

Dystopian commented Nov 12, 2017 •

edited

Loading

commy2 commented Nov 12, 2017

Dystopian commented Nov 12, 2017

commy2 commented Nov 12, 2017

commy2 commented Nov 12, 2017

Dystopian commented Nov 12, 2017

Dystopian commented Nov 26, 2017

Dystopian commented Dec 26, 2017

Dystopian commented Dec 30, 2017

PabstMirror commented Jan 1, 2018

dedmen left a comment

dedmen Oct 14, 2018

dedmen Oct 14, 2018

Dystopian Oct 14, 2018

dedmen Oct 16, 2018

Dystopian Oct 16, 2018

Dystopian Oct 23, 2018

dedmen Oct 23, 2018 •

edited

Loading

Dystopian Oct 23, 2018

Dystopian Oct 23, 2018 •

edited

Loading

dedmen Oct 24, 2018

dedmen Oct 14, 2018

Dystopian Oct 14, 2018

Dystopian commented Oct 23, 2018 •

edited

Loading

PabstMirror Oct 30, 2018

Dystopian Nov 5, 2018

Dystopian commented Nov 5, 2018

commy2 commented Nov 5, 2018

PabstMirror commented Nov 11, 2018

Dystopian commented Nov 15, 2018

jonpas commented Nov 18, 2018

Quick Mount - Add Get In and Change seat action menu #5745

Quick Mount - Add Get In and Change seat action menu #5745

Conversation

Dystopian commented Nov 12, 2017

jonpas commented Nov 12, 2017 • edited Loading

Dystopian commented Nov 12, 2017 • edited Loading

commy2 commented Nov 12, 2017

Dystopian commented Nov 12, 2017

commy2 commented Nov 12, 2017

commy2 commented Nov 12, 2017

Dystopian commented Nov 12, 2017

Dystopian commented Nov 26, 2017

Dystopian commented Dec 26, 2017

Dystopian commented Dec 30, 2017

PabstMirror commented Jan 1, 2018

dedmen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dedmen Oct 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dystopian Oct 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dystopian commented Oct 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dystopian commented Nov 5, 2018

commy2 commented Nov 5, 2018

PabstMirror commented Nov 11, 2018

Dystopian commented Nov 15, 2018

jonpas commented Nov 18, 2018

jonpas commented Nov 12, 2017 •

edited

Loading

Dystopian commented Nov 12, 2017 •

edited

Loading

dedmen Oct 23, 2018 •

edited

Loading

Dystopian Oct 23, 2018 •

edited

Loading

Dystopian commented Oct 23, 2018 •

edited

Loading