-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick Mount - Add Get In and Change seat action menu #5745
Merged
Merged
Changes from 37 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
c1b9ec8
Add quickmount GetIn menu
Dystopian 39c9c8b
Add compartment support
Dystopian 9e73ca8
Check engine, check pilot, check static turret driver
Dystopian 0222463
Add doc, condition, translation
Dystopian 9e17c18
Add hybrid config entries, fix MP issue
Dystopian 414d00e
Optimize condition
Dystopian 5316536
Ignore Enabled setting in vehicle
Dystopian 8af3296
Work around SQF validator macro issue
Dystopian 3e3993a
Fix config macro entries
Dystopian 02d5a69
Add workaround for getting damage when seat changing while moving
Dystopian 3b0d540
Merge remote-tracking branch 'upstream/master' into getin_menu
Dystopian 17ca955
Add setting for Get In menu disabling
Dystopian 7eccae8
Merge branch 'master' into getin_menu
Dystopian a66d97e
Fix race when 2 players try to get the same seat
Dystopian 81f711d
Convert if-else to switch
Dystopian 6cc77b8
Decrease move-back timeout to 0.5s
Dystopian 5dedfd4
Check if vehicle is flipped
Dystopian b03fde9
Merge remote-tracking branch 'upstream/master' into getin_menu
Dystopian a04b4c8
Merge branch 'master' into getin_menu
Dystopian 6a204d4
Add getin statement for parent menu
Dystopian fdc67c7
Improve canShowFreeSeats
Dystopian 7ac8515
Merge remote-tracking branch 'upstream/master' into getin_menu
Dystopian b70c904
Apply latest trends
Dystopian e472b02
Improve fnc_addFreeSeatsActions
Dystopian de71707
Merge remote-tracking branch 'upstream/master' into getin_menu
Dystopian 0e439af
Change copilot and gunless turret icons
Dystopian 8d59c9e
Fix macro name
Dystopian 5a02381
Fix FFV icon
Dystopian 283fae0
Optimize turret icon code
Dystopian fb01018
Extend setting to 4 values
Dystopian 5856d7b
Fix menu is shown when vehicle is full
Dystopian 09356d6
Optimize UAV checking code
Dystopian 493e5b3
Fix bug with disabled FFV turrets
Dystopian 59a97df
Merge remote-tracking branch 'upstream/master' into getin_menu
Dystopian 32e8e5d
Remove bugged FFV, Add turret locality check, Add Failed message
Dystopian 274ef00
Replace some macros with function
Dystopian 66b661d
Fix validator
Dystopian ef3cc84
Remove global variables, Add debug
Dystopian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
PREP(addFreeSeatsActions); | ||
PREP(canShowFreeSeats); | ||
PREP(getInNearest); | ||
PREP(moduleInit); |
244 changes: 244 additions & 0 deletions
244
addons/quickmount/functions/fnc_addFreeSeatsActions.sqf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,244 @@ | ||
#include "script_component.hpp" | ||
/* | ||
* Author: Dystopian | ||
* Creates actions for vehicle free seats. | ||
* | ||
* Arguments: | ||
* 0: Vehicle <OBJECT> | ||
* 1: Unit <OBJECT> | ||
* | ||
* Return Value: | ||
* Child actions <ARRAY> | ||
* | ||
* Example: | ||
* [cursorObject, player] call ace_quickmount_fnc_addFreeSeatsActions | ||
* | ||
* Public: No | ||
*/ | ||
|
||
#define TAKEN_SEAT_TIMEOUT 0.5 | ||
|
||
#define TO_COMPARTMENT_STRING(var) if !(var isEqualType "") then {var = format [ARR_2("Compartment%1",var)]} | ||
|
||
#define UNBLOCK_DAMAGE \ | ||
if (GETVAR(_this,GVAR(damageBlocked),false)) then { \ | ||
_this allowDamage true; \ | ||
SETVAR(_this,GVAR(damageBlocked),nil); \ | ||
}; | ||
|
||
// if unit isn't moved to new seat in TAKEN_SEAT_TIMEOUT, we move him back to his seat | ||
#define WAIT_IN_OR_MOVE_BACK \ | ||
[ARR_5( \ | ||
{!isNull objectParent _this}, \ | ||
{UNBLOCK_DAMAGE}, \ | ||
_player, \ | ||
TAKEN_SEAT_TIMEOUT, \ | ||
{ \ | ||
[ARR_2(_this,_this getVariable QGVAR(moveBackParams))] call (_this getVariable QGVAR(moveBackCode)); \ | ||
UNBLOCK_DAMAGE; \ | ||
localize "str_mis_state_failed" call EFUNC(common,displayTextStructured); \ | ||
} \ | ||
)] call CBA_fnc_waitUntilAndExecute; | ||
|
||
#define IS_MOVED_OUT \ | ||
( \ | ||
isNull objectParent _player \ | ||
&& { \ | ||
[] isEqualTo _currentTurret \ | ||
|| {local _target isEqualTo (_target turretLocal _currentTurret)} \ | ||
} \ | ||
) | ||
|
||
private _fnc_move = { | ||
(_this select 2) params ["_moveInCode", "_moveInParams", "_currentTurret", ["_enabledByAnimationSource", ""]]; | ||
|
||
// check bugged FFV | ||
if ( | ||
!("" isEqualTo _enabledByAnimationSource) | ||
&& {1 > _target doorPhase _enabledByAnimationSource} | ||
) exitWith {}; | ||
|
||
// workaround getting damage when moveOut while vehicle is moving | ||
if (isDamageAllowed _player) then { | ||
_player allowDamage false; | ||
SETVAR(_player,GVAR(damageBlocked),true); | ||
}; | ||
private _preserveEngineOn = _player == driver _target && {isEngineOn _target}; | ||
moveOut _player; | ||
if (_preserveEngineOn) then {_target engineOn true}; | ||
|
||
// moveIn right after moveOut doesn't work in MP for non-local vehicles, player just stays out | ||
// so we have to wait some time (e.g. until player is out and turret locality become vehicle locality) | ||
// usually it's done in the same frame for local vehicles/turrets and takes 3-7 frames for non-local, so in MP can look a little lagging | ||
if (IS_MOVED_OUT) exitWith { | ||
[_player, _moveInParams] call _moveInCode; | ||
WAIT_IN_OR_MOVE_BACK; | ||
}; | ||
[ | ||
{params ["", "_target", "_player", "", "_currentTurret"]; IS_MOVED_OUT}, | ||
{ | ||
params ["_moveInCode", "", "_player", "_moveInParams"]; | ||
[_player, _moveInParams] call _moveInCode; | ||
WAIT_IN_OR_MOVE_BACK; | ||
}, | ||
[_moveInCode, _target, _player, _moveInParams, _currentTurret] | ||
] call CBA_fnc_waitUntilAndExecute; | ||
}; | ||
|
||
#define ICON_DRIVER "A3\ui_f\data\IGUI\RscIngameUI\RscUnitInfo\role_driver_ca.paa" | ||
#define ICON_PILOT "A3\ui_f\data\IGUI\Cfg\Actions\getinpilot_ca.paa" | ||
#define ICON_CARGO "A3\ui_f\data\IGUI\RscIngameUI\RscUnitInfo\role_cargo_ca.paa" | ||
#define ICON_GUNNER "A3\ui_f\data\IGUI\Cfg\Actions\getingunner_ca.paa" | ||
#define ICON_COMMANDER "A3\ui_f\data\IGUI\RscIngameUI\RscUnitInfo\role_commander_ca.paa" | ||
#define ICON_TURRET "A3\ui_f\data\IGUI\RscIngameUI\RscUnitInfo\role_gunner_ca.paa" | ||
#define ICON_FFV "A3\ui_f\data\IGUI\Cfg\CrewAimIndicator\gunnerAuto_ca.paa" | ||
|
||
scopeName "main"; | ||
|
||
params ["_vehicle", "_player"]; | ||
|
||
private _vehicleConfig = configFile >> "CfgVehicles" >> typeOf _vehicle; | ||
private _isInVehicle = _player in _vehicle; | ||
private _fullCrew = fullCrew [_vehicle, "", true]; | ||
|
||
private ["_driverCompartments", "_isDriverIsolated", "_cargoCompartments", "_cargoCompartmentsLast", "_compartment", "_currentTurret"]; | ||
|
||
if (_isInVehicle) then { | ||
_driverCompartments = (_vehicleConfig >> "driverCompartments") call BIS_fnc_getCfgData; | ||
// Air class by default has driverCompartments=0 and cargoCompartments[]={0}, so we have to disable them | ||
_isDriverIsolated = _driverCompartments isEqualTo 0 && {_vehicle isKindOf "Air"}; | ||
TO_COMPARTMENT_STRING(_driverCompartments); | ||
|
||
_cargoCompartments = getArray (_vehicleConfig >> "cargoCompartments"); | ||
{ | ||
if !(_x isEqualType "") then { | ||
_cargoCompartments set [_forEachIndex, format ["Compartment%1", _x]]; | ||
}; | ||
} forEach _cargoCompartments; | ||
_cargoCompartmentsLast = count _cargoCompartments - 1; | ||
|
||
TRACE_2("",_driverCompartments,_cargoCompartments); | ||
|
||
// find current compartment | ||
( | ||
_fullCrew select (_fullCrew findIf {_player == _x select 0}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this will error if player is not in crew. Are you sure he is? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, |
||
) params ["", "_role", "_cargoIndex", "_turretPath"]; | ||
|
||
_currentTurret = _turretPath; | ||
|
||
switch (_role) do { | ||
case "driver": { | ||
if (_isDriverIsolated) then { | ||
[] breakOut "main"; | ||
}; | ||
_compartment = _driverCompartments; | ||
_player setVariable [QGVAR(moveBackCode), {(_this select 0) moveInDriver (_this select 1)}]; | ||
_player setVariable [QGVAR(moveBackParams), _vehicle]; | ||
}; | ||
case "cargo": { | ||
private _cargoNumber = fullCrew [_vehicle, "cargo", true] findIf {_player == _x select 0}; | ||
_compartment = _cargoCompartments select (_cargoNumber min _cargoCompartmentsLast); | ||
_player setVariable [QGVAR(moveBackCode), {(_this select 0) moveInCargo (_this select 1)}]; | ||
_player setVariable [QGVAR(moveBackParams), [_vehicle, _cargoIndex]]; | ||
}; | ||
default { | ||
private _turretConfig = [_vehicleConfig, _turretPath] call CBA_fnc_getTurret; | ||
_compartment = (_turretConfig >> "gunnerCompartments") call BIS_fnc_getCfgData; | ||
TO_COMPARTMENT_STRING(_compartment); | ||
_player setVariable [QGVAR(moveBackCode), {(_this select 0) moveInTurret (_this select 1)}]; | ||
_player setVariable [QGVAR(moveBackParams), [_vehicle, _turretPath]]; | ||
}; | ||
}; | ||
TRACE_4("",_role,_cargoIndex,_turretPath,_compartment); | ||
}; | ||
|
||
private _actions = []; | ||
private _cargoNumber = -1; | ||
{ | ||
scopeName "crewLoop"; | ||
_x params ["_unit", "_role", "_cargoIndex", "_turretPath", "_isPersonTurret"]; | ||
if (!isNull _unit && {alive _unit}) then { | ||
if (_role == "cargo") then { | ||
INC(_cargoNumber); | ||
}; | ||
} else { | ||
private ["_name", "_icon", "_statement", "_params"]; | ||
switch (toLower _role) do { | ||
case "driver": { | ||
if ( | ||
lockedDriver _vehicle | ||
|| {unitIsUAV _vehicle} | ||
|| {0 == getNumber (_vehicleConfig >> "hasDriver")} | ||
) then { | ||
breakTo "crewLoop"; | ||
}; | ||
if (_isInVehicle) then { | ||
if (_compartment != _driverCompartments || {_isDriverIsolated}) then {breakTo "crewLoop"}; | ||
_params = [{(_this select 0) moveInDriver (_this select 1)}, _vehicle, _currentTurret]; | ||
_statement = _fnc_move; | ||
} else { | ||
_params = ["GetInDriver", _vehicle]; | ||
_statement = {_player action (_this select 2)}; | ||
}; | ||
if (_vehicle isKindOf "Air") then { | ||
_name = localize "str_getin_pos_pilot"; | ||
_icon = ICON_PILOT; | ||
} else { | ||
_name = localize "str_driver"; | ||
_icon = ICON_DRIVER; | ||
}; | ||
}; | ||
case "cargo": { | ||
INC(_cargoNumber); | ||
if (_vehicle lockedCargo _cargoIndex) then {breakTo "crewLoop"}; | ||
if (_isInVehicle) then { | ||
if (_compartment != (_cargoCompartments select (_cargoNumber min _cargoCompartmentsLast))) then {breakTo "crewLoop"}; | ||
_params = [{(_this select 0) moveInCargo (_this select 1)}, [_vehicle, _cargoIndex], _currentTurret]; | ||
_statement = _fnc_move; | ||
} else { | ||
_params = ["GetInCargo", _vehicle, _cargoNumber]; | ||
_statement = {_player action (_this select 2)}; | ||
}; | ||
_name = format ["%1 %2", localize "str_getin_pos_passenger", _cargoNumber + 1]; | ||
_icon = ICON_CARGO; | ||
}; | ||
default { // all turrets including FFV | ||
if (_vehicle lockedTurret _turretPath) then {breakTo "crewLoop"}; | ||
if (_role == "gunner" && {unitIsUAV _vehicle}) then {breakTo "crewLoop"}; | ||
private _turretConfig = [_vehicleConfig, _turretPath] call CBA_fnc_getTurret; | ||
if (!_isInVehicle) then { | ||
_params = ["GetInTurret", _vehicle, _turretPath]; | ||
_statement = {_player action (_this select 2)}; | ||
} else { | ||
private _gunnerCompartments = (_turretConfig >> "gunnerCompartments") call BIS_fnc_getCfgData; | ||
TO_COMPARTMENT_STRING(_gunnerCompartments); | ||
if (_compartment != _gunnerCompartments) then {breakTo "crewLoop"}; | ||
// due to arma bug the unit is stuck in wrong anim when move in turret with configured enabledByAnimationSource | ||
private _enabledByAnimationSource = getText (_turretConfig >> "enabledByAnimationSource"); | ||
if ( | ||
!("" isEqualTo _enabledByAnimationSource) | ||
&& {1 > _vehicle doorPhase _enabledByAnimationSource} | ||
) then {breakTo "crewLoop"}; | ||
_params = [{(_this select 0) moveInTurret (_this select 1)}, [_vehicle, _turretPath], _currentTurret, _enabledByAnimationSource]; | ||
_statement = _fnc_move; | ||
}; | ||
_name = getText (_turretConfig >> "gunnerName"); | ||
_icon = switch true do { | ||
case (0 < getNumber (_turretConfig >> "isCopilot")): {ICON_PILOT}; | ||
case (_role == "gunner"): {ICON_GUNNER}; | ||
case (_role == "commander"): {ICON_COMMANDER}; | ||
case (_isPersonTurret): {ICON_FFV}; | ||
case ("" isEqualTo getText (_turretConfig >> "gun")): {ICON_CARGO}; | ||
default {ICON_TURRET}; | ||
}; | ||
}; | ||
}; | ||
private _action = [ | ||
format ["%1%2%3", _role, _cargoIndex, _turretPath], | ||
_name, _icon, _statement, {true}, {}, _params | ||
] call EFUNC(interact_menu,createAction); | ||
_actions pushBack [_action, [], _vehicle]; | ||
}; | ||
} forEach _fullCrew; | ||
|
||
_actions |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#include "script_component.hpp" | ||
/* | ||
* Author: Dystopian | ||
* Checks if Free Seats menu can be shown. | ||
* | ||
* Arguments: | ||
* 0: Vehicle <OBJECT> | ||
* 1: Unit <OBJECT> | ||
* | ||
* Return Value: | ||
* Can show menu <BOOL> | ||
* | ||
* Example: | ||
* [cursorObject, player] call ace_quickmount_fnc_canShowFreeSeats | ||
* | ||
* Public: No | ||
*/ | ||
|
||
params ["_vehicle", "_unit"]; | ||
|
||
private _isInVehicle = _unit in _vehicle; | ||
|
||
GVAR(enabled) | ||
&& { | ||
GVAR(enableMenu) == 3 | ||
|| {_isInVehicle && {GVAR(enableMenu) == 2}} | ||
|| {!_isInVehicle && {GVAR(enableMenu) == 1}} | ||
} | ||
&& {alive _vehicle} | ||
&& {2 > locked _vehicle} | ||
&& { | ||
-1 == crew _vehicle findIf {alive _x} | ||
|| {0.6 <= side group _unit getFriend side group _vehicle} | ||
} | ||
&& { | ||
0.3 < vectorUp _vehicle select 2 // moveIn* and GetIn* don't work for flipped vehicles | ||
|| {_vehicle isKindOf "Air"} // except Air | ||
} | ||
&& {!([] isEqualTo (_this call FUNC(addFreeSeatsActions)))} // this should be replaced with faster function |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
apply
Also you made a macro for this. Why don't you use it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look how it was with
apply
: 9e17c18#diff-ded96a376761ae515c888f369fb06b23R55I changed it to
forEach
only last days because IMHO it looks better and clearer.Macro sets variable not array member so I can't use it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will test in a week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apply
is slower (even without intermediatecargoCompartments
assignment) and less clear ✋There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand how it can be. If you are doing the same thing, but with less commands and less variables (forEachIndex) it shouldn't possibly be slower.
Edit: Ah understood now.
yeah they aren't. My variant copies _x if it's already a string. Yours just does nothing.
Do you have an example vehicle where cargoCompartments isn't actually an array of strings?
Oh okey.
Compartment1
is actually a enum that evaluates to 1.Compartment2 = 2
Compartment3 = 4
Compartment4 = 8 and so on.. Meh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.0083 ms
vs
0.0108 ms
when
cursorObject
isI_Truck_02_covered_F
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedmen when you edit your message nobody gets notification unlike when you create message (maybe in github desktop?). I really accidentally found your question.
CUP_Ural_ZU23_Base
,rhs_truck
,rhsusf_fmtv_base
and some more RHS vehicles. No in vanilla.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I expected you read the message on github. Instead of in a notification E-Mail or wherever.