Add ability to set aiming coefficient for mission scripting.

[xrufix]

When merged this pull request will:

• Add function ace_common_fnc_setAimCoef. This is a partial copy of the setHearingCapability function and allows for scripts to raise the aiming coefficient (weapon sway) above the current value. The highest value set will be applied. It is designed so that scripts can simulate stress, fear, suppression and other mental or physical conditions that will likely reduce a soldier's ability to aim correctly.
• Make ace_advanced_fatigue_fnc_handleEffects use the above-mentioned function instead of setCustomAimCoef.

I would however prefer a framework for similar functionality (having a max/min setting that can be set by different functions/scripts).

[Neviothr]

Space after ["_unit",.

[xrufix]

Done.

[PabstMirror]

@jlillis @xrufix any thoughts on this PR and #5773

They both do similar but different things to the same system.
Do we need both or would just adding the linear scaling factor in 5773 be enough?

I don't think it's a problem to add both (will be some minor merge conficts but should be easy to resolve)

[jlillis]

I think it would be better to modify #5773 so that when swayFactor is 0, advanced fatigue does not update setCustomAimCoef anymore. This would allow mission makers to customize the aiming coefficient in their own scripts.

[xrufix]

I think #5773 does something different. It will enable mission editors to change the impact of fatigue on weapon sway, not weapon sway itself (at least, not directly). It adds a factor which is multiplied with fatigues current setting. E.g. when you want to setCustomAimCoef 6, while standing still with no fatigue you would use a factor of 4. But when the player runs a bit this high factor will produce ridiculy high values.

My proposed solution does instead affect weapon sway directly. By checking for the highest set weapon sway, it produces more reliable and predictable results if a certain AimCoef is desired.

Merging and keeping both could be easily done and would imho be the best solution.

[jonpas]

Unit

[jonpas]

ID

[jonpas]

Settings and maybe add a note in () describing what exactly is meant.

[jonpas]

Add (true) or remove (false) <BOOL> (default: true)

[xrufix]

@jonpas Requested changes addressed. I also changed the file where i copy-pasted from.

[xrufix]

@commy2 This really needs #5773 to be merged (keeping my changes to fnc_handleEffects.sqf), otherwise GVAR(swayFactor) is undefined.

[commy2]

Easy fix :)

[Tee-ee-ee]

Sorry for digging the old post, but has this issue been solved? If so, what is currently the correct way to set the custom aim coefficient?
I pull the "Sway Factor" in ACE advanced fatigue all the way down to 0; then in the editor I put this in my player's init:
this setCustomAimCoef 0;
But I still get sway. The only valid way for the time being seems to completely disable the advanced fatigue to get no sway. Wondering if this is supposed to be the way to do it?

Update:
The problem seems to be in the fnc_setAimCoef.sqf line 24
it seems to make the lowest CustomAimCoef to be 1. Anything set lower than 1 using setCustomAimCoef will be overwritten to 1 cuz the script chooses the maximal value between the given number and 1.
It will be great if this minimum value can be adjusted via CBA settings such that mission makers can set custom sway values such as 50% sway, 25% sway, etc

[xrufix]

@Tee-ee-ee Please open a new issue to adress this.