Add cursor movement API #6162

LorenLuke · 2018-02-22T04:06:30Z

When merged this pull request will:

Add extensions capable of mimicking player mouse input.
Adds a function to 'common' to call the extension easily.

Notes:

Cursor movement in loops persists in dialog and pause menu.
Be sure to have safeguards in place before using in loops.

dedmen · 2018-02-22T07:25:16Z

extensions/cursor_movement/cursorMovement.cpp

+    ip.mi.time = 0;
+
+    int x, y;
+    if (strncmp(function, "x", 1)) {


use the advanced ballistics extension like format x:y so you can just send both.

Or maybe just use callExtensionArgs.

dedmen · 2018-02-22T07:26:41Z

addons/common/functions/fnc_moveCursor.sqf

+
+// "bluefcs" callExtension "x100"; "bluefcs" callExtension "y-100"
+// Yes, they're backwards. No, I can't fix it because I don't know how to DLL. -Luke
+call compile format ['"ace_cursor_movement" callExtension "y%1"',_x];


call compile format? really?
"ace_cursor_movement" callExtension format ["%1:%2",_x,_y]

~~April, April.~~ Yes, really.
I do stuff the way I know how that it works. If there's a better way, tell instead of condescending for not knowing the better way.

If there's a better way, tell instead of condescending for not knowing the better way.

Uhm...

"ace_cursor_movement" callExtension format ["%1:%2",_x,_y]

And my other comment about the format in the extension?

I didn't write the extension. I don't know how to .DLL.

And? Does that mean problems in your PR don't need to be fixed and can just be ignored?

dedmen

There is no protection to make sure that someone can't just move your cursor on your Desktop. At minimum this should check if Arma is in foreground and currently has focus.

dedmen · 2018-02-22T07:28:31Z

addons/common/functions/fnc_moveCursor.sqf

@@ -0,0 +1,30 @@
+/*
+ * Author: LorenLuke (function), BaerMitUmlaut (Extension)
+ * Simulates mouse input by number of pixels (not consistent/smooth)


Optional animated movement? linear or even specific curves?

Rotating a foot-mobile is all in one go, but vehicles had some sort of acceleration and cap on how fast you can traverse, meaning it has to be inputting for more than one frame to do much of anything.

What is a foot-mobile?

A person. Don't you play proper Arma, that's standard callout. :p

I intended this to mean adding animation handled in a second thread.
Which also solves:

meaning it has to be inputting for more than one frame to do much of anything.

Because you just tell it "Move that much over that much time"

Second thread also needs the "Arma in focus" check so we can't accidentally move the mouse outside of Arma. And it needs a limit. Bad guy could just launch a 10 hour animation...

IMO this feature could use Intercept. Intercept_CBA already has "Arma in focus" checks for the keybinding stuff. It could internally take care of dialog-open check and others. Instead of basing them on scripts which a bad-guy could just ignore by using callExtension directly.

dedmen · 2018-02-22T07:31:49Z

extensions/cursor_movement/cursorMovement.cpp

+        ip.mi.dy = atoi(&function[1]);
+        ip.mi.dx = 0;
+    }
+    else {


All other extensions use } else {.
else on same line.

dedmen · 2018-02-22T07:33:22Z

extensions/cursor_movement/cursorMovement.cpp

+        return;
+    }
+
+    SendInput(1, &ip, sizeof(INPUT));


Shouldn't it also return "error" if SendInput fails?

dedmen · 2018-02-22T07:35:24Z

Could also call this mouse extension and use it to click. But that needs even better protection so that it can't be missused.

Would also be nice to get MOUSEEVENTF_ABSOLUTE and a way to use Arma display coordinates. Aka float from 0-1 to move the mouse and have it automatically translate to the game window position/size.
I'd say that would be more usable. Because with just pixel offsets you cannot move the mouse precisely in ingame UI's as you don't know what resolution the player is running.

Also

Relative mouse motion is subject to the effects of the mouse speed and the two-mouse threshold values. A user sets these three values with the Pointer Speed slider of the Control Panel's Mouse Properties sheet.

Makes it even more imprecise.

I guess baer want's this for the flashbang stuff? It would break if the player happens to be in whatever state where his mouse doesn't control camera movement.

Yeees. I know I should've done one review with comments inside it instead of seperate comments. I always make that mistake 🗡️

EDIT: To the flashbang stuff. What I quoted above also means the flashbang effect is different depending on the Players mouse acceleration setting in Windows.

dedmen · 2018-02-22T07:41:47Z

addons/common/functions/fnc_moveCursor.sqf

+/*
+ * Author: LorenLuke (function), BaerMitUmlaut (Extension)
+ * Simulates mouse input by number of pixels (not consistent/smooth)
+ * Note- using with open dialogs may cause issues when in loops.


What kind of issues? Moving out of game window?

And pinning your cursor to the corner of the desktop/monitor like it's a professional wrestler waiting for a three-count.

dedmen · 2018-02-22T07:43:53Z

extensions/cursor_movement/cursorMovement.cpp

+        ip.mi.dx = atoi(&function[1]);
+        ip.mi.dy = 0;
+    }
+    else if (strncmp(function, "y", 1)) {


strncmp for just one character is a little overkill..
function[0] == 'y'

LorenLuke · 2018-02-22T10:15:10Z

@dedmen

https://github.com/LorenLuke/ACE3/blob/191f8cf0534f8608749c2e9ce58980ea1a019009/addons/common/functions/fnc_moveCursor.sqf#L2
https://github.com/LorenLuke/ACE3/blob/191f8cf0534f8608749c2e9ce58980ea1a019009/addons/common/functions/fnc_moveCursor.sqf#L25

The second half of both those lines are probably the best response I can give to like, 90% of your review.

LorenLuke · 2018-02-22T10:25:48Z

not precise motion.

The intended use is to call it within a PFH. Check that the game isn't paused and a dialogue isn't open, then use a constant angle check in to tandem with a PID controller to direct a correspondence towards an orientation.

dedmen · 2018-02-22T13:12:25Z

then use a constant angle check in to tandem with a PID controller to direct a correspondence towards an orientation.

Ehhh.... What?

Cuel · 2018-02-22T13:24:09Z

what's the purpose after merge? just wondering

LorenLuke · 2018-02-22T14:27:29Z

@dedmen

angle check in to tandem with a

Should have been 'in tandem with'. Also not proofread semi-pseudocode, because I'm on my phone.

Player setVariable ["autotrack", [0,0]];
onEachFrame { 
(player getVarable "autotrack") call func(move_cursor);
};

and just check angles between it and a desired aimpoint from there and feed them into the unit variable.

@Cuel I recall in the slack regarding #6034 that someone said they wouldn't mind if a vertical component could be added somehow. This could do just that. However original plans were for this to be used with a to-be-written Shtora defensive system framework, one of the components of which involves rotating the entire turret automatically to face an incoming rocket. With an AI or even nobody in the turret, that's doable; with a player in this, less so. Additional capabilities of this can include laying off some automatic artillery pieces and the creation of auto-tracking, radar-guided guns like the Shilka would be.

commy2 · 2018-02-22T14:49:47Z

Hunter-Killer for tanks.

Dystopian · 2018-02-22T17:10:48Z

Some time ago I was thinking about systems like Shilka: maybe it could be done with temporary moving player from main gunner to some other vehicle seat and creating UAV-like AI at gunner seat. AI could be ordered not fire till player orders.

commy2 · 2018-03-15T08:49:38Z

State?

dedmen · 2018-03-15T09:47:06Z

See all comments. Currently Stale it seems because author is unable to change stuff on the extension.
Unless you are just fine with ignoring all comments and just merging it.
Even the SQF only comments weren't addressed. Aka call compile format

PabstMirror · 2018-03-15T16:20:13Z

I think we should wait until we have an actual use for this

commy2

only one extension call should be used to change both X (0=left) and Y (0=top) (callExtensionArgs)
absolute change, pixels are useless
syntax for "move by X,Y from where you are now" and "move to X,Y regardless of where you are now"

Someone please explain to me why Windows has X as the ordinate. I am used to it being inverted by Arma too, but this just baffles me.

Ref.: https://community.bistudio.com/wiki/getMousePosition

For dialogs this function should probably just fall back to: https://community.bistudio.com/wiki/setMousePosition

I want this for Hunter-Killer :~)

LorenLuke · 2018-03-21T23:38:34Z

@dedmen
@commy2
As someone of variable and limited free time (why are there only 24 hours in a day?!), fluctuating mental health, and biting off more than I can chew with many other projects (missile guidance rework, MANPADS realistic functionality, Javelin realistic functionality introduction, MiniSpike television guidance, UAV vanilla module replacement/improvement) this PR has indeed gone somewhat stale, but it's not gone from my memory.

@PabstMirror
Uses for it would include commy's Hunter-Killer/slew-to-cue system, as well as auto tracking radar guided guns for the Tigris/Bardelas AA as well as 3rd party AA (ZSU Shilka), and Shtora active protection systems (intended to be compatible with the missile guidance rewrite).

Adds cursor movement.

191f8cf

dedmen reviewed Feb 22, 2018

View reviewed changes

dedmen suggested changes Feb 22, 2018

View reviewed changes

dedmen reviewed Feb 22, 2018

View reviewed changes

jonpas changed the title ~~Adds cursor movement.~~ Add cursor movement API Feb 22, 2018

PabstMirror added this to the Ongoing milestone Mar 15, 2018

commy2 added 3 commits March 18, 2018 14:01

newline eof

cbe59e1

formatting

5d479d7

simplify

b3e5936

commy2 suggested changes Mar 18, 2018

View reviewed changes

jonpas added kind/feature Release Notes: **ADDED:** status/WIP labels Dec 17, 2019

jonpas removed this from the Ongoing milestone Apr 20, 2021

jonpas added this to the Backlog milestone Apr 20, 2021

LorenLuke closed this Nov 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cursor movement API #6162

Add cursor movement API #6162

LorenLuke commented Feb 22, 2018

dedmen Feb 22, 2018 •

edited

Loading

dedmen Mar 1, 2018

dedmen Feb 22, 2018

LorenLuke Feb 22, 2018

dedmen Feb 22, 2018

LorenLuke Feb 22, 2018

dedmen Feb 22, 2018

dedmen left a comment

dedmen Feb 22, 2018

LorenLuke Feb 22, 2018

dedmen Feb 22, 2018

jonpas Feb 22, 2018

dedmen Mar 1, 2018 •

edited

Loading

dedmen Feb 22, 2018 •

edited

Loading

dedmen Feb 22, 2018

dedmen commented Feb 22, 2018 •

edited

Loading

dedmen Feb 22, 2018

LorenLuke Feb 22, 2018

dedmen Feb 22, 2018

LorenLuke commented Feb 22, 2018

LorenLuke commented Feb 22, 2018

dedmen commented Feb 22, 2018

Cuel commented Feb 22, 2018

LorenLuke commented Feb 22, 2018

commy2 commented Feb 22, 2018

Dystopian commented Feb 22, 2018

commy2 commented Mar 15, 2018

dedmen commented Mar 15, 2018 •

edited

Loading

PabstMirror commented Mar 15, 2018

commy2 left a comment

LorenLuke commented Mar 21, 2018

Add cursor movement API #6162

Add cursor movement API #6162

Conversation

LorenLuke commented Feb 22, 2018

dedmen Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dedmen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dedmen Mar 1, 2018 • edited Loading

Choose a reason for hiding this comment

dedmen Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dedmen commented Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LorenLuke commented Feb 22, 2018

LorenLuke commented Feb 22, 2018

dedmen commented Feb 22, 2018

Cuel commented Feb 22, 2018

LorenLuke commented Feb 22, 2018

commy2 commented Feb 22, 2018

Dystopian commented Feb 22, 2018

commy2 commented Mar 15, 2018

dedmen commented Mar 15, 2018 • edited Loading

PabstMirror commented Mar 15, 2018

commy2 left a comment

Choose a reason for hiding this comment

LorenLuke commented Mar 21, 2018

dedmen Feb 22, 2018 •

edited

Loading

dedmen Mar 1, 2018 •

edited

Loading

dedmen Feb 22, 2018 •

edited

Loading

dedmen commented Feb 22, 2018 •

edited

Loading

dedmen commented Mar 15, 2018 •

edited

Loading