Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to create zeus during mission #6203

Merged
merged 8 commits into from
Nov 10, 2018

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • add Create Zeus and Delete Zeus self-interaction menus, controlled with setting.

Player gets his own zeus object with all addons activated.

Still thinking about Debug console option at setting (means menu available if console is available), if it's needed at all and if its translation is OK next to None, Available for the host or logged-in admin and Available for everyone.

This feature is more for debugging and tests, not for production use.

@jonpas
Copy link
Member

jonpas commented Mar 19, 2018

Why not just add a button to pause menu, next to debug console?

@Dystopian
Copy link
Contributor Author

  • there is no really good place for such button;
  • too much work for such simple feature.

@PabstMirror
Copy link
Contributor

PabstMirror commented Mar 19, 2018

This feature is more for debugging and tests, not for production use.

It my experience, when creating a zeus module it causes a noticeable stutter on all machines
not that bad for most, but could cause issues for pilots

@Dystopian
Copy link
Contributor Author

yeah, I have those lags too. This feature really should be used with care.

@kymckay
Copy link
Member

kymckay commented Mar 20, 2018

Not sure how I feel about this one. It seems kind of out of place in ace to me.

@Dystopian
Copy link
Contributor Author

I can move it to optionals if you want.

@Dystopian
Copy link
Contributor Author

Also init code can be moved to setting change script, say if it's needed.

@shukari
Copy link
Contributor

shukari commented Apr 10, 2018

Cool feature! Is this still in dev or abandoned?
Would be really cool if admin and user with debugconsole access have a button in the esc menu.

@Dystopian
Copy link
Contributor Author

I deleted workaround for missed 3rd party vehicles in zeus because I can't reproduce it anymore. If anyone test the PR, check if vehicles are not missed in vehicles tree.

@Dystopian
Copy link
Contributor Author

Workaround is still necessary. I just load game (without filepatching) and load editor preview.

private _addons = ('true' configClasses (configFile >> "CfgPatches")) apply {configName _x};
activateAddons _addons;
removeAllCuratorAddons _zeus;
_zeus addCuratorAddons _addons;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a huge amount of addons causes a major lag on all clients. I never actually tried if the lag spike is gone if I remove the addons but it is my biggest suspect.
Should test that out and if it's really this the addons should be spread over a longer time. Many small lags over 10 seconds are better than half a second game freeze.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you talk about addCuratorAddons in multiplayer then ^^ if (!isMultiplayer.
If about _zeus setVariable ["Addons", 3, true] then nothing we can do and it's mentioned in comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First one yeah. I always do addCuratorAddons in my curator script. Didn't know it wasn't needed.

@PabstMirror PabstMirror added this to the 3.12.4 milestone Nov 10, 2018
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Nov 10, 2018
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@jonpas
Copy link
Member

jonpas commented Nov 10, 2018

I'd still prefer this in pause menu. Why add more clutter to self-interaction? I know it's only for admins, but I as an admin don't want it there.

https://github.com/CBATeam/CBA_A3/blob/master/addons/ui/fnc_addPauseMenuOption.sqf this function wasn't the case back in March, would this make it easier to add for you @Dystopian ?

@Dystopian
Copy link
Contributor Author

addPauseMenuOption requires dialog in params so I don't think it suits.

We use this feature for some months and it never was clutter in admin interaction menu. But it was VERY useful for debugging or testing something all the time.

I really don't mind if someone implements it in Esc menu any way, easy or complicated.

@jonpas
Copy link
Member

jonpas commented Nov 10, 2018

👍

@PabstMirror PabstMirror merged commit 32fc6bb into acemod:master Nov 10, 2018
@Dystopian Dystopian deleted the create_zeus branch November 10, 2018 20:36
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Add possibility to create zeus during mission

* Use LLSTRING

* Allow deleting when setting is disabled

* Delete canCreate function

* Delete workaround for missed vehicles

* Revert "Delete workaround for missed vehicles"

This reverts commit e33102e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants