Fix performance factor breaking stamina recovery

[BaerMitUmlaut]

When merged this pull request will:

• Fix performance factor breaking stamina recovery

From the original VBS documentation:

---

Acidosis accumulation
anaerobicFatigue += anaerobicDwork * maxPowerFatigueRatio * 1.1;
[...]
maxPowerFatigueRatio is a constant designed to scale the accumulation and recovery of anaerobicFatigue: maxPowerFatigueRatio = 0.057 / peakPower;

---

They might mean that it's a constant regardless of the actual peakPower, which is calculated from the VO₂max (which in turn is adjusted by the performance factor). This seems to fix issue #6163.

[ulteq]

I don't think that this is correct. But if it really fixes a gameplay issue. Go for it.

They might mean that it's a constant regardless of the actual peakPower

But then we would also have to change this line:

ACE3/addons/advanced_fatigue/functions/fnc_mainLoop.sqf

Line 70 in 14c9092

- (_ae1PathwayPowerFatigued + _ae2PathwayPowerFatigued - _ae1Power - _ae2Power) * (0.057 / GVAR(peakPower)) * GVAR(anFatigue) ^ 2 * GVAR(recoveryFactor)

[BaerMitUmlaut]

I don't think it's how it's meant either, this is more of a hotfix tbh. If you have an idea where else the problem might be let me know.

[ulteq]

I think part of the problem is that we derive _perceivedFatigue off anReserve. Which is not how it is meant to be done.

Instead we should use anFatique directly: https://github.com/acemod/ACE3/pull/5723/files#diff-0bdf0f3e6417972d88363532f5354a5aR114

[BaerMitUmlaut]

That's definitely not the underlying issue. The stamina bar displays only the anaerobic reserve which very visibly shows that it does essentially not recover at all. _perceivedFatigue is only used for feedback effects and has no influence on the recovery.

[ulteq]

That's definitely not the underlying issue.

Right.

What if the performance factor would also modify ANTPERCENT.

[ulteq]

1264.64 seems to be very high. Where did you get peakPower 0.00004507211 from?

[PabstMirror]

good catch, we just want to replace GVAR(peakPower) with the default value of 1264, not the whole term inside the ()

[PabstMirror]

Just to clarify my changes GVAR(peakPower) = 1264 under default values.

But I'm not sure if this is correct, line 58 increases fatigue and line 69 handles recovery.
Before both lines used the term (0.057 / GVAR(peakPower) to scale; this goes down as performance goes up.
This means that you had more reserves, but it also took longer to recover.

With this PR we change fatigue increase to ignore peakPower, but recovery still is negatively effected by it.

[ulteq]

I'm still not convinced by this PR. But I sadly don't have time to take a closer look.

One solution might be to finish this PR: #5723

It should be almost ready to go if we leave the Experimental movement speed limiter out.

I don't think this will work

[Mike-MF]

Closing due to age and/or inactivity, unlikely to be finished or has to be reworked due to other changes over the years. May be re-opened if someone finds it useful, even better just open a new up-to-date PR.