Common - Only switch side if necessary on person loading #6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
reviewed
May 19, 2018
| case (side _vehicle != side _unit): { | ||
| [_unit, true, GROUP_SWITCH_ID, side _vehicle] call FUNC(switchToGroupSide); | ||
| }; | ||
| }; |
There was a problem hiding this comment.
side OBJECT will report stuff like sideEnemy and sideFriendly. side GROUP will only report west, east, resistance, civilian. Are you sure you don't want to keep side group _something?
There was a problem hiding this comment.
Oh yes, my bad. I'll fix it.
There was a problem hiding this comment.
So will it be fixed and merged? We playing with this "fixed fix" for more than a year. But it is pain in the ass to track our temporary fixes on every ACE release. Would be nice to see solved issue in next release.
thojkooi
reviewed
Jul 7, 2018
|
Still relevant I assume? Looks like just needs a bit of a move. |
jonpas
changed the title
jonpas
approved these changes
Oct 10, 2021
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
Co-authored-by: Serg Vergun <1197314+severgun@users.noreply.github.com> Co-authored-by: jonpas <jonpas33@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Previously the unit would always switch to the side of the person loading the unit into the vehicle. That most likely did also not work when the loader has a different side than the crew of the vehicle. This should cover all cases.
Needs multiplayer testing.