Prevent bandaging when not bleeding #6532
Conversation
|
What about Contusion/Bruises? |
|
Bruises are actually what inspired this PR because there's no purpose to bandaging them (unless we restore the setting for bandages to heal damage - in which case this function can just exit with true if any wound is on the body part). |
| params ["_medic", "_patient", "_bodypart", "_bandage"]; | ||
|
|
||
| // Bandage type and bandage setting XNOR to show only active actions | ||
| if ((_bandage == "BasicBandage") isEqualTo GVAR(advancedBandages)) exitWith { false }; |
There was a problem hiding this comment.
While it works, this does not make things easier to understand imo.
There was a problem hiding this comment.
I agree that this isn't the most clear code, ideally we wouldn't even be adding the actions that aren't appropriate (unless we really care about the setting being toggleable mid-mission?).
|
When going down this road, we will also need to prevent morphine when a patient has no pain, or epi when the patient has a high high rate. I don't think this fits within the goal of ACE medical. Do we have a specific issue we are trying to address with this PR? |
|
If it's to address the issue where it's confusing to some people that bruises cannot be bandaged, we should look into either A) remove bruises or B) find a different method to display bruises. |
|
I don't really see the point in punishing the user for mistaking the UI. |
The difference is that morphine and epi still have an effect and there is an actual decision to be made as to whether it's appropriate to apply them. Whereas bandaging when there's no bleeding has no feedback and just results in wasted bandages, it's not engaging gameplay. |
|
Think about it this way: In real life you might accidentally make the wrong call in administering medication, but you'd never accidentally bandage a non-bleeding body part. |
|
Maybe this can be an optional thing? I personaly appreciate the change but I guess some people will opose it.... |
|
Correct me if im wrong but i think the core issue here is that the selectable areas on arms/legs/head in the medical menu are either smaller than the picture of the arm (for example) or the exact same size with no tolerance. Only time i bandage something that doesn't need it is because i was convinced i had clicked on the correct area. |
|
+1 on the matter of wasting bandages and time because you're bandaging the wrong body part. |
|
😱 |
When merged this pull request will:
This a quality of life improvement because there's never a situation where you'd want to bandage a body part that isn't bleeding.