Add Vehicle Damage (ACE2 port) & Enhance Cook-Off

[TheCandianVendingMachine]

When merged this pull request will:

• Port over ACE 2 Vehicle Damage
• Remove vehicle damage from cookOff module
• Enhance cook-off effects

Some magic numbers exist, most of them are either direct ports from ACE 2 or I just forgot to remove them. Most of them are there for calculations however and are static anyhow.

A bunch of config entries get added through this. Most of them are required or else you get a very subpar implementation

It should work automatically with most mod vehicles with some alright default settings

In testing it seems to work reliably with no unreasonable lack of vehicle damage occurring, however I need to test with mod vehicles to ensure cross compatibility with minimal effort. The only config changes are to define ERA and SLAT hitpoints as well as giving custom burn chances for hits to certain areas. Ammo also needs to have an incendiary value defined if it is indeed incendiary

Todo:

• Test in multiplayer - Result: all effects are global and no effects are duplicated. G2G
• Test with various mod vehicles - Result: Tested with RHS against RHS, Vanilla against RHS, and RHS against vanilla. All interactions are as expected. Even CUP seems to work out of the box (mostly). G2G
• Test in a large scale environment
• Polishing

Video of it in action

Infantry on fire after cookoff

Requires #8245

[TheCandianVendingMachine]

with this latest commit idk if that's how I'm "supposed" to do required addons. I just added every config that I touched

[Whigital]

I'm no expert, so correct me if i'm wrong, but the required vanilla A3 CfgPatches (A3_Data_F_Enoch_Loadorder and A3_Data_F_Mod_Loadorder) are implicitly added through cba_common -> cba_main -> ace_main -> ace_common.

So only ace modules that this is dependent on needs to be in there ....

[shukari]

some german translations
@bux can you check it

[shukari]

Suggested change

	<English>ACE Fire</English>
	<English>ACE Fire</English>
	<German>ACE Feuer</German>

[shukari]

Suggested change

	<English>Pat Down Fire</English>
	<English>Pat Down Fire</English>
	<German>Feuer ausklopfen</German>

[shukari]

Suggested change

	<English>Patting Down Fire</English>
	<English>Patting Down Fire</English>
	<German>Feuer ausklopfen</German>

[shukari]

Suggested change

	<English>Enable</English>
	<English>Enable</English>
	<German>Aktivieren</German>

[shukari]

Suggested change

	<English>ACE Advanced Vehicle Damage</English>
	<English>ACE Advanced Vehicle Damage</English>
	<German>ACE Erweiterter Fahrzeugschaden</German>

[shukari]

Suggested change

	<English>Enable</English>
	<English>Enable</English>
	<German>Aktivieren</German>

[shukari]

Suggested change

	<English>Enable/Disable advanced vehicle damage</English>
	<English>Enable/Disable advanced vehicle damage</English>
	<German>Aktiviert/Deaktiviert das erweiterte Fahrzeugschadenssystem</German>

[shukari]

Suggested change

	<English>Enable/Disable advanced car damage (Experimental)</English>
	<English>Enable/Disable advanced car damage (Experimental)</English>
	<German>Aktiviert/Deaktiviert das erweiterte Autoschadenssystem (Experimentell)</German>

[shukari]

Suggested change

	<English>Enable/Disable advanced Car Damage</English>
	<English>Enable/Disable advanced Car Damage</English>
	<German>Aktiviert/Deaktiviert das erweiterte Autoschadenssystem</German>

[jonpas]

Need to fix merge conflicts.

[nomisum]

We had 2 games now with the following issue occuring:

Crew gets heavily injured or even killed by light collisions of vehicle with tree.

[TheCandianVendingMachine]

Can't reproduce

[nomisum]

Can't reproduce

Hmmmm... I will try to find out more details. Possibly GM/Weferlingen related or sth.

could not repro either :(

[SzwedzikPL]

I've played small dedicated MP game with it with CUP and GM without any issues. Looked like everything worked as intended.

Played it on master 76676ee + this PR.

[nomisum]

Longing for this to be merged. Its optional anyway so no big risk 😅

[rautamiekka]

There seems to be a typo somewhere in the 1.1 Adding a new fire source cuz everything since is broken.

[TheCandianVendingMachine]

Wouldn't these statements make more sense (just like it's generally adviced) to check _mass == 0 once, then branch out into the isClass checks ?

if (_mass == 0) then {
    if (isClass (_config >> "itemInfo")) then {
        _mass = getNumber (_config >> "itemInfo" >> "mass");
    };

    if (isClass (_config >> "WeaponSlotsInfo")) then {
        _mass = getNumber (_config >> "WeaponSlotsInfo" >> "mass");
    };
};

Couldn't find if elseif exists.

I don't think you are on the right PR

[jonpas]

@shukari can you PR translations separately? GitHub considers them outdated as that file got changed, plus Fire is split into a separate component now.

[jonpas]

Has been playtested for over a year at @PabstMirror's and @TheCandianVendingMachine's group.

[shukari]

Yeah no problem