Vehicles - Utilize setCruiseControl for speed limiter

[AndreasBrostrom]

When merged this pull request will:

• Change speed limiter to utalize setCruiseControl

Adjustments and code of note:

• Kept setVelocity with a +2 to speed check to make vehicle slow down downhill and to slow it down when enabled.
• Still use the per frame due to ctrl+scroll adjustment check and active breake.

REQUIRE ARMA Version v2.06 >

[Drofseh]

I don't know if you want to do it in this PR, but someway to have autoThrust as true to do actual cruise control would be nice to have at some point

[AndreasBrostrom]

I don't know if you want to do it in this PR, but someway to have autoThrust as true to do actual cruise control would be nice to have at some point

I can experiement with it in a nother pr.

[jonpas]

https://forums.bohemia.net/forums/topic/140837-development-branch-changelog/?page=58&tab=comments#comment-3438862

Changes to cruise control from today.

[AndreasBrostrom]

Tweaked: Cruise control now aborts the speed limit when you brake manually

the script reapply it if i am not mistaken. will check effects.

Tweaked: Cruise control now lets you drive faster than the target speed when you apply manual thrust

should not effect this pr

[dedmen]

Kept setVelocity with a +2 to speed check to make vehicle slow down downhill and to slow it down when enabled.

speed limiter will apply brakes if you are too fast.
setVelocity is unrealistic and will stop you immediately, thats bad

[AndreasBrostrom]

The cruise control do not activly slow you down when your going down hill wich is the resoning why i kept the setVelocity as mentioned.
In normal cases you enable the speed limiter with delete key and a sudden slow down in speed whould never apply.

I did not have the setVelocity breaker in the begining. But after testing were i manage go over ~20km/h of the speed limit.
With the setVelocity, to no suprce never reached, over set speed +2.

[dedmen]

The cruise control do not activly slow you down when your going down hill wich is the resoning

It should actively brake though.
I just looked at the code again
if (abs(curSpeed-setpoint) > setpoint*0.2f && speed>setpoint)
brakeWanted = 0.5;

The first check is to limit the PID controller to a smaller range, outside of the range its manually controlled, inside its controlled by the PID.

so if your limit is 50kmh if your speed delta is more than 20% (10kmh) above setpoint it will apply 50% brakes and force thrust to 0.
Then when you come within 20% of setpoint the brakes will be removed and thrust will be controlled by the PID (which will immediately apply low thrust as you are above setpoint)

I only did 50% brakes to make it a little smoother, maybe thats not sufficient for your downhill test.

My main concern is the "exploit" where you just quickly mouse-wheel your speed down if you need to quickly stop to apply the "magic" brakes.

Maybe the "magic" brake can be disabled if you just reduced speed via mouse wheel in the last 2-5 seconds?

[dedmen]

Okey I just tested, because the PID controller only controls thrust and not brakes (while you are within the 10kmh delta) you will go 60kmh downhill when speedlimit is set to 50 (testing on malden mountain)
The PID controller can go negative so I will adjust the code to apply brakes too.

[AndreasBrostrom]

Okey I just tested, because the PID controller only controls thrust and not brakes (while you are within the 10kmh delta) you will go 60kmh downhill when speedlimit is set to 50 (testing on malden mountain)
The PID controller can go negative so I will adjust the code to apply brakes too.

feel free to adjust

[dedmen]

Okey I fixed it.
Looks good to me. of course theres a little over/undershoot but looks good enough.
Also found another bug, speed limiter only applied when forward thrust was applied, meaning you could just roll downhill and not be stopped. Fixed that too.

https://youtu.be/36od_7hFr7w

log bottom right

Thrust, Brake, PID output

Will be in next RC build this week. Maybe profiling branch if I do one
The wiki page was also updated with more details about how it works https://community.bistudio.com/wiki/setCruiseControl

[veteran29]

Mission makers might want to limit the speed of certain vehicles for whatever reason, I think we should limit the max limiter speed to the value of the limit at the time of Speedlimiter activation.

[Zakant]

Mission makers might want to limit the speed of certain vehicles for whatever reason, I think we should limit the max limiter speed to the value of the limit at the time of Speedlimiter activation.

I'm against this. We often activate the speed limiter when not moving at all to have clear 5 km/h steps. Otherwise vehicles end up driving 43 and 47 km/h. And for players i dont see the benefit. One could just disable it, speed up and reenable it?

[jonpas]

I am confused, are @veteran29's and @Zakant's comments even related? One seems to speak about upper-most value that can be restricted from a perspective of a mission maker, and another speaks of value when you activate.

If I am not mistaken, what @Zakant is saying is actually how it works before this PR. You can still increase it by step. Someone explain?

[veteran29]

I think Zakant does not understand what I meant. His comment does not make sense to me.

[veteran29]

What I meant about respecting mission maker set limit is basically this...

when speed limiter is engaged, outside of PFH:

GVAR(maxSpeedLimit) = getCruiseControl _vehicle select 0;
if (GVAR(maxSpeedLimit) == 0) then {
    GVAR(maxSpeedLimit) = 1e10;
};

inside the PFH:

    getCruiseControl _vehicle params ["_currentSpeedLimit"];
    if (_currentSpeedLimit != GVAR(speedLimit)) then {
        _vehicle setCruiseControl [GVAR(speedLimit) min GVAR(maxSpeedLimit), false];
    };

I guess the limit should be enforced in the handler of the "increase limit" function instead of the PFH but this should explain what I've meant.

[PabstMirror]

@veteran29 Does that last sound ok?

[veteran29]

@veteran29 Does that last sound ok?

I guess it's ok for now, allowing to use the feature and restoring the mission set limit would be better but can be done in another PR.