Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Vehicles - Utilize setCruiseControl for speed limiter (#8273)" #8614

Closed
wants to merge 1 commit into from

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Oct 24, 2021

The change of PR-#8273 does not work, at least not for specific vehicles. It makes them completely uncontrollable.

I see no reason to use this new script command here. This is a speed limiter, and not "cruise control". Please add your own feature if you want that, and leave this one alone. It has been tested and tweaked alot, and has been used for years, and nobody ever complained. The players in my comm like how it worked, and the new one not in a usable state.

Thank you.

@commy2 commy2 added the kind/bug-fix Release Notes: **FIXED:** label Oct 24, 2021
@mjc4wilton
Copy link
Contributor

Haven't played with the new update much yet but I remember old cruise control was very stuttery and made it impossible for turrets to operate well, so I don't believe praising the old one as perfect is completely valid.

@veteran29
Copy link
Member

The old setVelocity based speed limiter was stuttery for everyone but vehicle drivers which made it impossible to aim when for example used in tanks.

@Dystopian
Copy link
Contributor

This is a speed limiter, and not "cruise control"

setCruiseControl should work both as speed limiter and cruise control depending on params.

Maybe what dedmen said in #8273 about per frame command call should be fixed.

@jonpas
Copy link
Member

jonpas commented Oct 24, 2021

nobody ever complained

I don't complain about a project I work on, because I could have changed it myself, but I have noted several times before there was an alternative, setVelocity makes it way too laggy to be enjoyably driving with it. @veteran29 it has even been stuttery for drivers. I resorted to binding my flight pedal's toe brakes to vehicle throttle and stopped using speed limiter until now.

@jonpas
Copy link
Member

jonpas commented Oct 28, 2021

#8643

@jonpas jonpas closed this Oct 28, 2021
@jonpas jonpas deleted the fix-speed-limiter branch October 28, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants