Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interact Menu - Combine parent menu with single child #8060

Merged
merged 5 commits into from
Feb 4, 2021

Conversation

Dystopian
Copy link
Contributor

@Dystopian Dystopian commented Jan 6, 2021

When merged this pull request will:

  • add setting to combine parent menu with single child;
  • adapt fastroping Cut ropes action for the setting;
  • clean up chemlights and map menu configs a little.

Setting is disabled by default. Still not sure about setting name and description.

3

@veteran29 veteran29 added the kind/enhancement Release Notes: **IMPROVED:** label Jan 6, 2021
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works. Nice feature 👍

@PabstMirror
Copy link
Contributor

Really minor, but I want to test how this will work with #6876
where I used the child as a "safety"
I think we can just add a dummy statement if it's a problem

@mharis001 mharis001 added this to the 3.13.6 milestone Jan 7, 2021
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this if child action has different object
e.g. a single passenger won't show any interactions because the object was still on the vehicle

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@Dystopian
Copy link
Contributor Author

@PabstMirror please review the last commit

@PabstMirror PabstMirror merged commit 08472f6 into acemod:master Feb 4, 2021
@Dystopian Dystopian deleted the eat-lonely-child-menu branch February 5, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants